ENT-14090: Stopped using system_owned in copy_from acceptance tests (3.24.x)#6132
Merged
Merged
Conversation
After plucked.sub.cf was regenerated from masterfiles, system_owned picks a group by platform class -- on Solaris that is "sys" (gid 3). The destination is created with the agent's effective gid (0), so copy_from with preserve => "true" propagated the source group to the destination and emitted an unexpected "Group of ... was 0, set to 3" log line on Solaris. Define a local agent_owned perms body that sets owner and group from sys.user_data, matching the agent's effective uid/gid. The destination is then created with the same uid/gid as the source, so preserve has no ownership diff to apply and no spurious log lines appear. This mirrors the pre-regeneration behavior of system_owned, which used $(sys.user_data[gid]) for the group. Ticket: ENT-14090 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
force-pushed
the
copy-from-tests-3.24.x
branch
from
5280f57 to
27db964
Compare
craigcomstock
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
plucked.sub.cfwas regenerated from masterfiles (commit a8a4aa2 on 3.24.x), thesystem_ownedbody sets group tosys(gid 3) on Solaris specifically. The destination file created bycopy_fromwithpreserve => "true"is opened with the agent's effective gid (0), soVerifyCopiedFileAttributesdetects the mismatch against the source's gid and emits an extraGroup of ... was 0, set to 3log line that isn't in the.expectedoutput. This caused28_inform_testing/01_files/copy_from01.cfandcopy_from03.cfto start failing on Solaris 11.