Replace JS worker's rendezvous channel with unbounded queue#4704
Merged
joshua-spacetime merged 2 commits intomasterfrom Apr 6, 2026
Merged
Replace JS worker's rendezvous channel with unbounded queue#4704joshua-spacetime merged 2 commits intomasterfrom
joshua-spacetime merged 2 commits intomasterfrom
Conversation
joshua-spacetime
force-pushed
the
joshua/js-worker-queue
branch
from
5dfa03f to
12bbb3e
Compare
joshua-spacetime
changed the title
joshua-spacetime
force-pushed
the
joshua/js-worker-queue
branch
from
12bbb3e to
86bb26a
Compare
joshua-spacetime
changed the title
joshua-spacetime
force-pushed
the
joshua/js-worker-queue
branch
from
86bb26a to
b36c84d
Compare
joshua-spacetime
force-pushed
the
joshua/js-worker-queue
branch
from
b36c84d to
1b76be1
Compare
Centril
previously requested changes
Mar 27, 2026
Contributor
|
On phoenix nap, using the rust client, I get:
The difference with this PR is at 12k TPS 🚀 |
Collaborator
|
I'll review after the changes requested by Mazdak are made |
joshua-spacetime
force-pushed
the
joshua/js-worker-queue
branch
3 times, most recently
from
6c005a6 to
77faa0d
Compare
joshua-spacetime
force-pushed
the
joshua/js-worker-queue
branch
from
77faa0d to
02dd1b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Previously, a module’s JS worker thread was fed through a zero-capacity channel. That made every request handoff a rendezvous between the async producer task and the single JS worker thread. Under high concurrency, that synchronous handoff showed up as hot
flume/lock/wakeup stacks on the critical path - the JS worker thread.This patch brings V8 execution in line with WASM which also uses an unbounded request queue.
Changing that handoff to an unbounded queue decouples request producers from the JS worker. Producers can enqueue work without synchronizing directly with the worker on every request, and the worker can continue draining queued requests without paying the rendezvous cost each time. This shortens the critical path, reduces scheduler/locking overhead and increases throughput.
API and ABI breaking changes
None
Expected complexity level and risk
2
Testing
Manual performance testing