argocd-bootstrap.tf: restore bin/argocd-bootstrap (k8s/reorg)#71926
Draft
argocd-bootstrap.tf: restore bin/argocd-bootstrap (k8s/reorg)#71926
Conversation
…m_release" This reverts commit e0082e1.
Contributor
Author
|
Concrete failure snippet from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR preserves the Ruby-owned Argo bootstrap branch on a side branch so it can be reviewed or revived later without keeping it on
k8s/reorg. We rolledk8s/reorgback to the simplerhelm_releasepath for the next real full apply/destroy cycle, but the script branch is still worth keeping as a concrete alternative because it captured one real design idea: bootstrap-only apply, and a destroy-only attempt to refresh Helm state from the latestk8s-gitopschart before final uninstall.What went wrong in the test run is now clear from the logs. The destroy-side
bin/argocd-bootstrappath ranhelm upgrade --installbeforehelm uninstall, and that reconcile was not a drop-in operation against a live self-managed Argo install. It failed on two separate fronts. First, the live Argo install was already managing the same resources, and the reconcile hit field-manager ownership conflicts againstargocd-controlleronargocd-notifications-secret, the repo secrets (repo-code-dot-org,repo-k8s-gitops,repo-kargo-charts),Deployment/argocd-applicationset-controller,Deployment/argocd-repo-server, andStatefulSet/argocd-application-controller. Second, the cluster was dirty from an earlier cleanup mistake, so the reconcile also failed validation on the Argo ingress because the AWS load balancer webhook had no endpoints (no endpoints available for "aws-load-balancer-webhook-service"). The combined result is that the script branch is not merge-ready as-is: its pre-destroy Helm reconcile assumption is too optimistic once Argo has been self-managing the same release.Technical changes:
terraform_data.argocd_bootstrapas the Argo bootstrap owner ink8s/tofu/codeai-k8s/cluster-infra-argocd/argocd-bootstrap.tfk8s/tofu/codeai-k8s/cluster-infra-argocd/bin/argocd-bootstrapapplyinstalls/bootstrap only and refuses Helm upgrades of an existing releasedestroyis the only mode allowed to attempt a Helm refresh before uninstallhelm_releasebaseline