security: high-severity dependency fixes and Node 20 engines#317
Closed
thomasrockhu-codecov wants to merge 7 commits intomainfrom
Closed
security: high-severity dependency fixes and Node 20 engines#317thomasrockhu-codecov wants to merge 7 commits intomainfrom
thomasrockhu-codecov wants to merge 7 commits intomainfrom
Conversation
Pins nuxt and @nuxt/kit to the 3.16 line (resolves to 3.16.2) so installs include the cache-poisoning DoS fix (GHSA-jvhm-gjrh-3h93) and updated devtools transitive dependencies (e.g. simple-git GHSA-r275-fr43-pm7q). Uses ~3.16.0 instead of ^3.16.0 to avoid unintentionally jumping to Nuxt 3.17+ during this security pass. Made-with: Cursor
Coerce null asset gzipSize before matching so Bun snapshot matchers (expect.any(Number)) work. Refresh Nuxt generate-bundle-stats snapshots after the Nuxt ~3.16 upgrade; use Any<String> for bundler/plugin versions. Made-with: Cursor
Use ^3.16.0 for nuxt and @nuxt/kit where sibling deps use ^; refresh lockfile. Made-with: Cursor
- Add pnpm overrides for transitive fixes (minimatch, cross-spawn, tar, undici, h3, devalue, path-to-regexp, rollup, etc.) and pin vite 6.4.1 - Upgrade Next examples and plugin devDeps to 15.2.9; Astro 5.15.8+; Rollup 4.59.x; lodash 4.18; @actions/core; lint-staged 16; changesets - Align integration test apps; migrate astro-4 fixture to Astro 5 for patched advisory range; constrain Nuxt to ~3.16.2 to avoid vite 7 drift - Fix vitest configs for @rollup/plugin-replace + Rollup 4.59 types; use import attributes `with` in bundle-analyzer vitest config - Remove global glob@10 override (breaks @rollup/plugin-commonjs); audit remains clear of high severity Made-with: Cursor
Align root, all published packages, and examples that declared >=18.0.0 (or >=18) with engines.node >=20.0.0. Made-with: Cursor
Resolve Nuxt semver conflicts by keeping ~3.16.2 pins; bring in main workflow updates for test-api and typedoc deploy. Made-with: Cursor
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Prevent Tests Dashboard |
- Apply prettier fixes in bundler-plugin-core (transports, types) - Use inline type imports in vitest configs (import/consistent-type-specifier-style) Made-with: Cursor
| "@codecov/astro-plugin": "workspace:*", | ||
| "@types/react": "^19.0.1", | ||
| "@types/react-dom": "^19.0.2", | ||
| "astro": "^5.15.8", |
There was a problem hiding this comment.
This directory is called test-apps/astro-4 but we've changed astro to be 5.15.8, the same as the astro-5 directory's version. This seems like we are losing coverage
Contributor
Author
There was a problem hiding this comment.
nice catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR clears high-severity findings from
pnpm auditand aligns declared Node support with current CI (Node 20+).Dependency / audit hardening
pnpm.overridesfor patched transitive versions (e.g. minimatch, cross-spawn, tar, undici, h3, devalue, path-to-regexp, rollup) and pin Vite 6.4.1 workspace-wide where needed for consistent resolution.pnpm-lock.yaml.~3.16.2to avoid unintended Vite 7 drift; integration snapshot updates where applicable.glob@10override (breaks@rollup/plugin-commonjsdefault import); audit remains clear of high without it.@rollup/plugin-replace+ Rollup 4.59 typing; bundle-analyzerimportuseswith: { type: "json" }.Engines
engines.nodeto>=20.0.0everywhere that previously declared>=18/>=18.0.0.Verification
pnpm audit: no high severitypnpm run type-checkpnpm run test:unit:ciMade with Cursor