Bump the all-dependencies group across 1 directory with 2 updates#150
Open
dependabot[bot] wants to merge 2 commits intomainfrom
Open
Bump the all-dependencies group across 1 directory with 2 updates#150dependabot[bot] wants to merge 2 commits intomainfrom
dependabot[bot] wants to merge 2 commits intomainfrom
Conversation
dependabot
bot
added
dependencies
* fix: prevent zip-slip path traversal in AddExtension (GHSA-8x9r-hvwg-c55h) ExtractZip passed raw zip entry names to a callback that wrote files using filepath.Join with no boundary check, allowing a malicious VSIX to write arbitrary files outside the extension directory (zip-slip / CWE-22). The same issue existed in the extra-files loop. Fix: open an os.Root on the target directory before extraction and perform all writes through it. os.Root enforces containment at the syscall level (openat), blocking "../" traversal, absolute paths, symlink escapes, and TOCTOU races — unlike the lexical prefix-check approach it replaces. Requires Go 1.24+, already the module minimum. Two regression tests added (local backends only): - AddExtensionZipTraversal: VSIX with a "../../../" entry is rejected - AddExtensionExtraTraversal: extra File with traversal path is rejected * Add test cases for absolute path and symlink traversal in AddExtension Covers two additional attack vectors blocked by os.Root: - Absolute paths (e.g. /tmp/evil) in zip entries and extra files - Symlink inside the extension directory pointing outside the root Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Bump Go to 1.25.8 and replace mkdirAllRoot with root.MkdirAll os.Root.MkdirAll was added in Go 1.25, removing the need for the custom mkdirAllRoot helper and its infinite-recursion fix for absolute paths. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Bumps the all-dependencies group with 2 updates in the / directory: [golang.org/x/mod](https://github.com/golang/mod) and [golang.org/x/sync](https://github.com/golang/sync). Updates `golang.org/x/mod` from 0.33.0 to 0.34.0 - [Commits](golang/mod@v0.33.0...v0.34.0) Updates `golang.org/x/sync` from 0.19.0 to 0.20.0 - [Commits](golang/sync@v0.19.0...v0.20.0) --- updated-dependencies: - dependency-name: golang.org/x/mod dependency-version: 0.34.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: golang.org/x/sync dependency-version: 0.20.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/all-dependencies-1d521d86e4
branch
from
ba651ea to
75eb96b
Compare
jdomeracki-coder
force-pushed
the
main
branch
2 times, most recently
from
6a75570 to
3a9adbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the all-dependencies group with 2 updates in the / directory: golang.org/x/mod and golang.org/x/sync.
Updates
golang.org/x/modfrom 0.33.0 to 0.34.0Commits
1ac721dgo.mod: update golang.org/x dependenciesfb1fac8all: upgrade go directive to at least 1.25.0 [generated]Updates
golang.org/x/syncfrom 0.19.0 to 0.20.0Commits
ec11c4aerrgroup: fix a typo in the documentation1a58307all: modernize interface{} -> any3172ca5all: upgrade go directive to at least 1.25.0 [generated]