refactor: migrate to git-bot-feedback lib#304
Conversation
9945499 to
0d59e1c
Compare
resolves #97 This has 2 main benefits: 1. Improved PR review support. The [git-bot-feedback] lib automatically hides outdated suggestions and reviews. 2. Any further CI platform support can get implemented in the [git-bot-feedback] lib. This way, cpp-linter gets the newly supported CI platforms for "free." [git-bot-feedback]: https://github.com/2bndy5/git-bot-feedback
0d59e1c to
89d1c26
Compare
We don't need to see all logs for passing tests
remove unused functions transition to git CLI in tests This is a small step toward removing our dependence on libgit2
460d9b4 to
30e0efe
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
==========================================
- Coverage 92.60% 90.94% -1.66%
==========================================
Files 26 22 -4
Lines 4339 3368 -971
==========================================
- Hits 4018 3063 -955
+ Misses 321 305 -16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
329c03f to
5767d37
Compare
for windows canonical path to git test patch asset
This project's production code never does `git clone`, so we really shouldn't need the `https` feature of the `git2` crate enabled.
5767d37 to
e4f7145
Compare
7854340 to
b8539a7
Compare
Installing clang tools is now part of the tested production code. We don't need a dedicated GH action to do that anymore.
|
Warning Review limit reached
More reviews will be available in 47 minutes and 29 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughMigrate internal REST/filtering to a new RestClient backed by git-bot-feedback, add typed error enums, adapt clang-tools and FileObj flows to structured errors, rewire run_main and tests to use RestClient and updated file filters, and update CI/tooling/manifests and fixtures. ChangesRest client and pipeline migration
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
|
about saturating subtraction and collapsing an else if logic paths
should remove some tests that are not dependent on clang tools.
7ad0037 to
fdf8705
Compare
only clang-related tests run on other clang versions. should short-circuit the 20 minute wait just to see if all tests pass in CI.
Looks like the all production code in the git module is no longer actually used, not in tests nor production. So what remains is just the regressions tests. refactored the new rest_client logic a bit, mainly just removing lines that are never triggered by tests.
458c876 to
8cb6254
Compare
resolves #97
This has 2 main benefits:
During review, I found a way to remove dependence on OpenSSL in both libgit2 and reqwest libraries. We are now using rustls as our TLS backend for HTTP requests.
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Chores