Merged
Conversation
also moving the test file to the more general test_sqlcompleter.py. Adding the tests uncovered a small bug in sqlcompleter.py: a rapidfuzz candidate could have been appended to the list of candidates even when it was a duplicate.
rolandwalker
force-pushed
the
RW/add-sqlcompleter-test-coverage
branch
from
d6bee35 to
d456691
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extend tests for
SQLCompleter, also moving the test file to the more generaltest_sqlcompleter.py.Adding the tests uncovered a small bug in
sqlcompleter.py: a rapidfuzz candidate could have been appended to the list of candidates even when it was a duplicate.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).