Skip to content

feat(typings): Add pyrefly type checker#101

Draft
tkislan wants to merge 3 commits into
mainfrom
tk/add-pyrefly-type-check
Draft

feat(typings): Add pyrefly type checker#101
tkislan wants to merge 3 commits into
mainfrom
tk/add-pyrefly-type-check

Conversation

@tkislan
Copy link
Copy Markdown
Contributor

@tkislan tkislan commented May 18, 2026

Summary by CodeRabbit

  • Chores
    • Added a CI step to run an additional static-check tool as part of existing type-checking.
    • Added the static-check tool to development dependencies and project configuration.
    • Added a baseline file to record and suppress existing diagnostics for the new checks.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 95bc2c6e-174b-4d57-bbb0-aba80e78043f

📥 Commits

Reviewing files that changed from the base of the PR and between 66a2afc and 9caa357.

📒 Files selected for processing (1)
  • deepnote_toolkit/sql/sql_execution.py

📝 Walkthrough

Walkthrough

This PR integrates pyrefly, a type-checking tool, into the deepnote-toolkit CI pipeline. The changes add pyrefly as a dev dependency, configure it in pyproject.toml with project scope and error mappings that mirror the existing mypy checks, establish a baseline JSON file documenting pre-existing type diagnostics across four modules, and wire a new CI step into the mypy job to run pyrefly checks post-build.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Updates Docs ⚠️ Warning PR adds pyrefly type checker but no documentation files modified. CONTRIBUTING.md lacks type-checking tool guidance. Update CONTRIBUTING.md: document pyrefly purpose, how to run locally, baseline management, and CI integration.
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat(typings): Add pyrefly type checker' accurately describes the main change—integrating pyrefly as a new type checking tool into the project's CI and configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

📦 Python package built successfully!

  • Version: 2.3.0.dev4+5b77efd
  • Wheel: deepnote_toolkit-2.3.0.dev4+5b77efd-py3-none-any.whl
  • Install:
    pip install "deepnote-toolkit @ https://deepnote-staging-runtime-artifactory.s3.amazonaws.com/deepnote-toolkit-packages/2.3.0.dev4%2B5b77efd/deepnote_toolkit-2.3.0.dev4%2B5b77efd-py3-none-any.whl"

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yml:
- Around line 211-214: The "Run pyrefly" workflow step currently runs without an
explicit condition so it uses the default if: success() and can be skipped after
mypy failures; update the step that runs "poetry run pyrefly check
--output-format min-text" (the step named "Run pyrefly") to include if: always()
so pyrefly diagnostics are executed and reported regardless of previous job
status.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bdf45fdd-663c-40c5-a98f-9920b0a1be48

📥 Commits

Reviewing files that changed from the base of the PR and between 8bb3cef and 8b4c6b3.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • pyproject.toml
  • pyrefly-baseline.json

Comment thread .github/workflows/ci.yml
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.96%. Comparing base (8bb3cef) to head (9caa357).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   73.96%   73.96%           
=======================================
  Files          95       95           
  Lines        5669     5669           
  Branches      843      843           
=======================================
  Hits         4193     4193           
  Misses       1200     1200           
  Partials      276      276           
Flag Coverage Δ
combined 73.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepnote-bot
Copy link
Copy Markdown

deepnote-bot commented May 18, 2026

🚀 Review App Deployment Started

📝 Description 🌐 Link / Info
🌍 Review application ra-101
🔑 Sign-in URL Click to sign-in
📊 Application logs View logs
🔄 Actions Click to redeploy
🚀 ArgoCD deployment View deployment
Last deployed 2026-05-18 08:58:35 (UTC)
📜 Deployed commit 83b6260e0501267aba3ee586284dd62a5b68eef3
🛠️ Toolkit version 5b77efd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants