feat(typings): Add pyrefly type checker#101
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR integrates pyrefly, a type-checking tool, into the deepnote-toolkit CI pipeline. The changes add pyrefly as a dev dependency, configure it in pyproject.toml with project scope and error mappings that mirror the existing mypy checks, establish a baseline JSON file documenting pre-existing type diagnostics across four modules, and wire a new CI step into the mypy job to run pyrefly checks post-build. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Comment |
|
📦 Python package built successfully!
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 211-214: The "Run pyrefly" workflow step currently runs without an
explicit condition so it uses the default if: success() and can be skipped after
mypy failures; update the step that runs "poetry run pyrefly check
--output-format min-text" (the step named "Run pyrefly") to include if: always()
so pyrefly diagnostics are executed and reported regardless of previous job
status.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: bdf45fdd-663c-40c5-a98f-9920b0a1be48
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
.github/workflows/ci.ymlpyproject.tomlpyrefly-baseline.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
=======================================
Coverage 73.96% 73.96%
=======================================
Files 95 95
Lines 5669 5669
Branches 843 843
=======================================
Hits 4193 4193
Misses 1200 1200
Partials 276 276
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
🚀 Review App Deployment Started
|
Summary by CodeRabbit