fix(copilot-cli): use semver sort for prerelease tag resolution#1657
Open
Copilot wants to merge 5 commits into
Open
fix(copilot-cli): use semver sort for prerelease tag resolution#1657Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix prerelease channel to sort tags by version
fix(copilot-cli): use semver sort for prerelease tag resolution
May 19, 2026
Kaniska244
approved these changes
May 19, 2026
abdurriq
requested changes
May 20, 2026
Contributor
|
@copilot Check this review comment #1657 (comment) |
…d add test Extract the prerelease tag resolution logic into a standalone resolve_prerelease_version() function that can read from stdin for testing. Add a scenario test that validates version sorting with mock git ls-remote data to prevent regressions.
Kaniska244
requested changes
May 21, 2026
Remove the stdin/cat fallback and use ${1:?} to error if no URL is
provided. Update the test to mock git via PATH instead of piping stdin.
Kaniska244
approved these changes
May 21, 2026
abdurriq
reviewed
May 21, 2026
Comment on lines
+12
to
+14
| | awk '{print $2}' | sed 's|refs/tags/||' \ | ||
| | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+(-[0-9]+)?$' \ | ||
| | sort -V | tail -n1 |
Contributor
There was a problem hiding this comment.
My intention was that we test just this part (without the git part to simplify tests), and also without rewriting the function. Happy to approve to unblock this but would appreciate if we can have this as a follow-up.
abdurriq
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
prereleasechannel resolves the install candidate viagit ls-remote --tags | tail -1, which sorts alphabetically. This picksv1.0.9overv1.0.45because"9" > "4"lexicographically.Fix: Replace the alphabetic tail with a version-sorted pipeline:
vX.Y.Z[-N]tags (excludes stray refs)sort -V(version sort) instead of relying on git's lexicographic order1.1.2→1.1.3