Update default Greclipse version#2924
Conversation
jochenberger
force-pushed
the
update-greclipse
branch
3 times, most recently
from
662e5fe to
18db411
Compare
|
Huh? Why do the Gradle builds fail? Any idea @nedtwigg? |
|
I can reproduce the |
jochenberger
force-pushed
the
update-greclipse
branch
from
18db411 to
d240894
Compare
|
See also #2926 |
jochenberger
force-pushed
the
update-greclipse
branch
4 times, most recently
from
a54b599 to
d52237c
Compare
jochenberger
force-pushed
the
update-greclipse
branch
2 times, most recently
from
91f533f to
b6251f8
Compare
| P2ModelWrapper modelWrapper = P2ModelWrapper.wrap(model); | ||
| List<File> classpath = p2Provisioner.provisionP2Dependencies(modelWrapper, mavenProvisioner, cacheDirectory); | ||
| // work around https://github.com/equodev/equo-ide/pull/193 | ||
| classpath = classpath.stream().filter(f -> !f.getName().contains("groovy-test")).toList(); |
There was a problem hiding this comment.
I need to find a cleaner way to do this. Any help is appreciated.
jochenberger
force-pushed
the
update-greclipse
branch
from
fcc5d47 to
0d39b4d
Compare
jochenberger
force-pushed
the
update-greclipse
branch
from
0d39b4d to
eae4d3a
Compare
jochenberger
changed the title
| List<File> classpath = p2Provisioner.provisionP2Dependencies(modelWrapper, mavenProvisioner, cacheDirectory).stream() | ||
| // work around https://github.com/equodev/equo-ide/pull/193 | ||
| .filter(f -> !f.getName().contains("groovy-test")) |
There was a problem hiding this comment.
Yeah? It actually felt a bit hackish to me, but if you approve, I'm fine obviously. 🙂
There was a problem hiding this comment.
Test code is one of the things that OSGi makes super complicated. It shouldn't be included in the first place, and by stripping it out you avoid a lot weird cases.
| "org.codehaus.groovy.eclipse.core", | ||
| "org.eclipse.jdt.groovy.core", | ||
| "org.codehaus.groovy")); | ||
| model.addFilterAndValidate("no-debug", filter -> filter.exclude("org.eclipse.jdt.debug")); |
There was a problem hiding this comment.
@jochenberger you could maybe try this approach to remove groovy-test. The advantage is that it should also prevent transitive dependencies of groovy-test from getting sucked in, but if what you have works I see no reason to spend more of your time on it.
2 participants
Bump groovy-eclipse to 6.1.0