Skip to content

cli/command/container: inline uses of streams.Out.CheckTty#6902

Open
thaJeztah wants to merge 1 commit intodocker:masterfrom
thaJeztah:inline_tty_check
Open

cli/command/container: inline uses of streams.Out.CheckTty#6902
thaJeztah wants to merge 1 commit intodocker:masterfrom
thaJeztah:inline_tty_check

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 29.3.2 milestone Apr 1, 2026
@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Apr 1, 2026
@thaJeztah
Copy link
Copy Markdown
Member Author

Something failing and a linting issue; will have a look, but this one's not urgent

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/container/attach.go 0.00% 7 Missing ⚠️
cli/command/container/exec.go 0.00% 1 Missing and 1 partial ⚠️
cli/command/container/run.go 0.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants