refactor: remove unused LogDir function and related logs endpoint logic#819
Closed
ilopezluna wants to merge 1 commit intomainfrom
Closed
refactor: remove unused LogDir function and related logs endpoint logic#819ilopezluna wants to merge 1 commit intomainfrom
ilopezluna wants to merge 1 commit intomainfrom
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the /logs HTTP endpoint and the associated LogDir configuration logic from the model runner. The changes include the removal of the endpoint registration in main.go and the environment variable helper in pkg/envconfig/envconfig.go. I have no feedback to provide.
doringeman
approved these changes
Apr 1, 2026
| }) | ||
|
|
||
| // Logs endpoint (Docker Desktop mode only). | ||
| if logDir := envconfig.LogDir(); logDir != "" { |
Contributor
There was a problem hiding this comment.
We should try to make this work with remote/manual contexts, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused env var.