Skip to content

Make llama.cpp Python cleanup optional#957

Merged
ilopezluna merged 1 commit into
mainfrom
fix-optional-llamacpp-python-cleanup
Jun 5, 2026
Merged

Make llama.cpp Python cleanup optional#957
ilopezluna merged 1 commit into
mainfrom
fix-optional-llamacpp-python-cleanup

Conversation

@ilopezluna
Copy link
Copy Markdown
Contributor

Summary

  • make llama.cpp native Dockerfile Python helper cleanup tolerant when no *.py files are installed
  • apply the same cleanup behavior across generic, CUDA, ROCm, CANN, and MUSA Dockerfiles

Testing

  • rg -n 'RUN rm install/bin/\\*\\.py' llamacpp/native\n- rg -n 'RUN rm -f install/bin/\\*\\.py' llamacpp/native\n- git diff --check\n\n## Notes\nThis keeps existing cleanup behavior when Python helper files are present, while avoiding a Docker build failure for builds where CMake install does not produce install/bin/*.py.\n

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several Dockerfiles (cann, cuda, generic, musa, and rocm) to use the force flag (rm -f) when deleting Python files from the installation directory, preventing potential build failures if no such files exist. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@ilopezluna ilopezluna marked this pull request as ready for review June 5, 2026 10:26
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ilopezluna ilopezluna merged commit 4d9cbce into main Jun 5, 2026
14 checks passed
@ilopezluna ilopezluna deleted the fix-optional-llamacpp-python-cleanup branch June 5, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants