Fix ConnectTimeout XML doc comment: default is 24 hours, not 120 seconds#11463
Merged
Conversation
5 tasks
Agent-Logs-Url: https://github.com/dotnet/android/sessions/c6c135f5-1251-48d2-bf23-271ab5095391 Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ConnectTimeout XML doc comment for accuracy
Fix ConnectTimeout XML doc comment: default is 24 hours, not 120 seconds
May 23, 2026
jonathanpeppers
approved these changes
May 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the XML documentation for AndroidMessageHandler.ConnectTimeout to reflect the actual default value used in code (24 hours), aligning it with the existing ReadTimeout documentation and the TimeSpan.FromHours (24) initializer.
Changes:
- Correct
ConnectTimeoutdefault value in XML doc comment from 120 seconds to 24 hours. - Cross-reference
ReadTimeoutin theConnectTimeoutdocumentation for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectTimeoutdoc comment stated default is 120 seconds, but the initializer isTimeSpan.FromHours(24). Updated to match reality and be consistent withReadTimeoutdoc above it.