Finish remaining C# 9 diagnostics#53888
Open
BillWagner wants to merge 7 commits into
Open
Conversation
This diagnostics incidates you found a bug in the compiler. Good job.
This assumes a search won't uncover related errors for build configs.
I don't want the index.md to be a catch-all, so create a speciic file for command line options and build config issues. This created more opportunities for consolidation.
Several existing diagnostics were consolidated around the theme of invalid build configurations.
Consolidate around themes for this area of diagnostics.
proofread
Contributor
There was a problem hiding this comment.
Pull request overview
This PR finishes documenting remaining C# 9 diagnostics by moving several previously “catchall/undocumented” build and command-line-related error codes into a new consolidated article, updating topic pages for the remaining C# 9 diagnostics, and wiring up TOC and redirects for removed per-code pages.
Changes:
- Add
invalid-build-command-line.mdto document build/command-line/configuration diagnostics (including CS8751, CS8771, and CS8772) in one place. - Move C# 9 diagnostics to the appropriate existing topic pages (constructor, operator overloads, and attributes), and remove them from the “sorry we don’t have specifics” catchall.
- Remove several old per-code pages and add redirects + TOC updates to keep links working.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/csharp/misc/sorry-we-don-t-have-specifics-on-this-csharp-error.md | Removes newly documented diagnostics from the catchall keyword list (but introduces a duplicate keyword entry). |
| docs/csharp/misc/cs3013.md | Deletes per-code page in favor of consolidated guidance. |
| docs/csharp/misc/cs3012.md | Deletes per-code page in favor of consolidated guidance. |
| docs/csharp/misc/cs2036.md | Deletes per-code page in favor of consolidated guidance. |
| docs/csharp/misc/cs2029.md | Deletes per-code page in favor of consolidated guidance. |
| docs/csharp/misc/cs2019.md | Deletes per-code page in favor of consolidated guidance. |
| docs/csharp/misc/cs2008.md | Deletes per-code page in favor of consolidated guidance. |
| docs/csharp/misc/cs1719.md | Deletes per-code page in favor of consolidated guidance. |
| docs/csharp/misc/cs1668.md | Deletes per-code page in favor of consolidated guidance. |
| docs/csharp/language-reference/toc.yml | Adds the new consolidated article to the compiler messages TOC and removes direct entries for deleted pages. |
| docs/csharp/language-reference/compiler-messages/overloaded-operator-errors.md | Adds CS8761 coverage and keywords to the operator diagnostics topic. |
| docs/csharp/language-reference/compiler-messages/invalid-build-command-line.md | New consolidated diagnostics article (contains a broken relative link and a couple of clarity/typo issues). |
| docs/csharp/language-reference/compiler-messages/index.md | Updates metadata date for the compiler messages index page. |
| docs/csharp/language-reference/compiler-messages/cs2032.md | Deletes per-code page in favor of consolidated guidance. |
| docs/csharp/language-reference/compiler-messages/cs1616.md | Deletes per-code page in favor of consolidated guidance. |
| docs/csharp/language-reference/compiler-messages/cs1564.md | Deletes per-code page in favor of consolidated guidance. |
| docs/csharp/language-reference/compiler-messages/cs0016.md | Deletes per-code page in favor of consolidated guidance. |
| docs/csharp/language-reference/compiler-messages/cs0007.md | Deletes per-code page in favor of consolidated guidance. |
| docs/csharp/language-reference/compiler-messages/cs0006.md | Deletes per-code page in favor of consolidated guidance. |
| docs/csharp/language-reference/compiler-messages/constructor-errors.md | Adds CS8760 coverage and keywords to the constructor diagnostics topic. |
| docs/csharp/language-reference/compiler-messages/attribute-usage-errors.md | Adds CS8783 coverage and keywords to the attribute diagnostics topic. |
| .openpublishing.redirection.csharp.json | Adds redirects from removed per-code pages to the new consolidated article. |
Comments suppressed due to low confidence (1)
docs/csharp/language-reference/compiler-messages/invalid-build-command-line.md:121
- The CS1773 entry repeats "Invalid version version..." in the section list. If the compiler message doesn't include the repeated word, fix the typo here as well so both lists match.
- **CS1773**: *Invalid version version for /subsystemversion. The version must be 6.02 or greater for ARM or AppContainerExe, and 4.00 or greater otherwise*
- **CS2019**: *Invalid target type for /target: must specify 'exe', 'winexe', 'library', or 'module'*
- **CS2029**: *Invalid name for a preprocessing symbol; 'identifier' is not a valid identifier*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53549
New file for command line and build config issues consolidates several existing error codes and takes more off the undocumented backlog.
Internal previews