Add regression test: #13114, SynPat.Record and QuoteExpr traversal#19468
Open
Add regression test: #13114, SynPat.Record and QuoteExpr traversal#19468
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
added
NO_RELEASE_NOTES
Contributor
|
T-Gro
force-pushed
the
regression-test/issue13114
branch
from
5ffaa13 to
05b03f5
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
force-pushed
the
regression-test/issue13114
branch
from
05b03f5 to
3dabfa6
Compare
abonie
reviewed
Mar 27, 2026
tests/FSharp.Compiler.ComponentTests/ConstraintSolver/MemberConstraints.fs
Show resolved
Hide resolved
abonie
reviewed
Mar 27, 2026
…d FromParseError - Remove the SRTP matrix inverse test from MemberConstraints.fs: it references issue #9382 and is unrelated to this PR (#13114). - Add SynPat.IsInst test: verifies defaultTraverse descends into the SynType inside :? type-test patterns. - Add SynPat.FromParseError test: verifies defaultTraverse descends into the nested pattern wrapped by FromParseError. Per reviewer feedback from @abonie. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Commit pushed:
|
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Commit pushed:
|
…g still present) SynPat.IsInst is not in the traversePat defaultTraverse in ServiceParseTreeWalk.fs, so the test asserting it works was failing on all platforms. Keeping Record, QuoteExpr, and Paren (FromParseError-labelled) tests which pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Commit pushed:
|
This comment has been minimized.
This comment has been minimized.
12 tasks
…Traverse Add SynPat.IsInst and SynPat.FromParseError cases to the defaultTraverse function in traversePat (ServiceParseTreeWalk.fs): - SynPat.IsInst: traverses into the SynType via traverseSynType - SynPat.FromParseError: traverses into the wrapped SynPat Add regression test for SynPat.IsInst traversal using :? type test pattern. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
auduchinok
reviewed
Mar 31, 2026
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Commit pushed:
|
Contributor
|
🤖 This is an automated response from Regression PR Shepherd. Addressed | SynPat.IsInst(ty, _) -> traverseSynType path ty
|
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13114