Skip to content

Add regression test: #10043, backtick should not report unexpected keyword#19476

Open
T-Gro wants to merge 3 commits intomainfrom
regression-test/issue10043
Open

Add regression test: #10043, backtick should not report unexpected keyword#19476
T-Gro wants to merge 3 commits intomainfrom
regression-test/issue10043

Conversation

@T-Gro
Copy link
Copy Markdown
Member

@T-Gro T-Gro commented Mar 24, 2026

Adds a regression test for #10043

Verifies that let i:float1 = 3.0` produces FS3563 ("This is not a valid identifier") instead of the previous confusing "Unexpected reserved keyword" message.

Fixes #10043

@T-Gro T-Gro requested a review from a team as a code owner March 24, 2026 10:42
@T-Gro T-Gro added NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes AI-Issue-Regression-PR PR adding regression test for a closed issue labels Mar 24, 2026
@T-Gro T-Gro requested a review from abonie March 24, 2026 10:42
@T-Gro T-Gro enabled auto-merge (squash) March 24, 2026 10:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2026

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@auduchinok
Copy link
Copy Markdown
Member

auduchinok commented Mar 24, 2026

The backticks cases were added in the previous PRs. It's more interesting to see if there are any @ or ! cases.

@T-Gro T-Gro force-pushed the regression-test/issue10043 branch from ea3d696 to f498636 Compare March 24, 2026 13:10
@T-Gro
Add regression tests for #10043: backtick, @, and ! in type annotations
e7b6ee5 
Tests that invalid characters in type annotation positions produce clear
error messages instead of confusing 'Unexpected reserved keyword':
- backtick: FS3563 'This is not a valid identifier'
- @: FS0615 'Unexpected infix operator in type expression'

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@T-Gro T-Gro force-pushed the regression-test/issue10043 branch from f498636 to e7b6ee5 Compare March 24, 2026 13:16
@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Mar 30, 2026
@github-actions github-actions bot mentioned this pull request Mar 31, 2026
Open
12 tasks
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Apr 1, 2026
Open
11 tasks
@github-actions
Rebase: add missing Issue 6715 and 15655 tests from main to resolve m…
106a756 
…erge conflict

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Commit pushed: 3c1ebc9

Generated by Regression PR Shepherd

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

🤖 This is an automated response from Regression PR Shepherd.

The branch was rebased onto current main this morning to resolve a merge conflict. The CI check is now showing action_required — the GitHub Actions workflow run needs a maintainer to approve it before the Azure DevOps pipelines will trigger.

@T-Gro @abonie — could you approve the workflow run so CI can proceed? The PR itself is clean: no unresolved review threads, and the rebase only re-ordered <Compile Include> entries in the .fsproj.

Generated by Regression PR Shepherd · ◷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonie abonie abonie approved these changes

Assignees

No one assigned

Labels

AI-Issue-Regression-PR PR adding regression test for a closed issue NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unexpected keyword error when there's no keyword

3 participants

@T-Gro @auduchinok @abonie