Skip to content

Remove shared cursor images that have been deprecated for removal #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 1 commit into from
Jun 5, 2026
+98 −712
Merged

Remove shared cursor images that have been deprecated for removal #4064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 98 additions & 0 deletions bundles/org.eclipse.ui.workbench/.settings/.api_filters
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,103 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<component id="org.eclipse.ui.workbench" version="2">
<resource path="eclipseui/org/eclipse/ui/ISharedImages.java" type="org.eclipse.ui.ISharedImages">
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_BOTTOM_MASK"/>
</message_arguments>
</filter>
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_BOTTOM_SOURCE"/>
</message_arguments>
</filter>
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_INVALID_MASK"/>
</message_arguments>
</filter>
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_INVALID_SOURCE"/>
</message_arguments>
</filter>
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_LEFT_MASK"/>
</message_arguments>
</filter>
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_LEFT_SOURCE"/>
</message_arguments>
</filter>
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_OFFSCREEN_MASK"/>
</message_arguments>
</filter>
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_OFFSCREEN_SOURCE"/>
</message_arguments>
</filter>
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_RIGHT_MASK"/>
</message_arguments>
</filter>
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_RIGHT_SOURCE"/>
</message_arguments>
</filter>
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_STACK_MASK"/>
</message_arguments>
</filter>
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_STACK_SOURCE"/>
</message_arguments>
</filter>
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_TOFASTVIEW_MASK"/>
</message_arguments>
</filter>
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_TOFASTVIEW_SOURCE"/>
</message_arguments>
</filter>
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_TOP_MASK"/>
</message_arguments>
</filter>
<filter id="405864542">
<message_arguments>
<message_argument value="org.eclipse.ui.ISharedImages"/>
<message_argument value="IMG_OBJS_DND_TOP_SOURCE"/>
</message_arguments>
</filter>
</resource>
<resource path="eclipseui/org/eclipse/ui/dialogs/YesNoCancelListSelectionDialog.java" type="org.eclipse.ui.dialogs.YesNoCancelListSelectionDialog">
<filter id="576778288">
<message_arguments>
Expand Down
212 changes: 0 additions & 212 deletions bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/ISharedImages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,218 +449,6 @@ public interface ISharedImages {
*/
String IMG_TOOL_UP_DISABLED = "IMG_TOOL_UP_DISABLED"; //$NON-NLS-1$

// The following set of constants represent the image pairs that are used
// to construct cursors for drag and drop operations within the workbench
// Each cursor is represented by two images; the 'source' and the 'mask'
// These need to be combined using the following code snippet:
// source = getImageDescriptor(sourceId);
// mask = getImageDescriptor(maskId);
// cursor = new Cursor(display, source.getImageData(), mask.getImageData(), 16,
// 16);

/**
* Cursor 'source' for the left arrow cursor. For cursor construction see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated Dropped in favor of {@link #IMG_OBJS_DND_LEFT}. The replacement
* icon does <b>not</b> require a mask.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_LEFT_SOURCE = "IMG_OBJS_DND_LEFT_SOURCE"; //$NON-NLS-1$
/**
* Cursor 'mask' for the left arrow cursor. For cursor construction see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated No longer needed with {@link #IMG_OBJS_DND_LEFT}.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_LEFT_MASK = "IMG_OBJS_DND_LEFT_MASK"; //$NON-NLS-1$

/**
* Cursor 'source' for the right arrow cursor. For cursor construction see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated Dropped in favor of {@link #IMG_OBJS_DND_RIGHT}. The replacement
* icon does <b>not</b> require a mask.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_RIGHT_SOURCE = "IMG_OBJS_DND_RIGHT_SOURCE"; //$NON-NLS-1$
/**
* Cursor 'mask' for the right arrow cursor. For cursor construction see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated No longer needed with {@link #IMG_OBJS_DND_RIGHT}.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_RIGHT_MASK = "IMG_OBJS_DND_RIGHT_MASK"; //$NON-NLS-1$

/**
* Cursor 'source' for the up arrow cursor. For cursor construction see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated Dropped in favor of {@link #IMG_OBJS_DND_TOP}. The replacement
* icon does <b>not</b> require a mask.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_TOP_SOURCE = "IMG_OBJS_DND_TOP_SOURCE"; //$NON-NLS-1$
/**
* Cursor 'mask' for the up arrow cursor. For cursor construction see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated No longer needed with {@link #IMG_OBJS_DND_TOP}.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_TOP_MASK = "IMG_OBJS_DND_TOP_MASK"; //$NON-NLS-1$

/**
* Cursor 'source' for the down arrow cursor. For cursor construction see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated Dropped in favor of {@link #IMG_OBJS_DND_BOTTOM}. The replacement
* icon does <b>not</b> require a mask.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_BOTTOM_SOURCE = "IMG_OBJS_DND_BOTTOM_SOURCE"; //$NON-NLS-1$
/**
* Cursor 'mask' for the down arrow cursor. For cursor construction see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated No longer needed with {@link #IMG_OBJS_DND_BOTTOM}.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_BOTTOM_MASK = "IMG_OBJS_DND_BOTTOM_MASK"; //$NON-NLS-1$

/**
* Cursor 'source' for the 'no drop' arrow cursor. For cursor construction see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated Dropped in favor of {@link #IMG_OBJS_DND_INVALID}. The
* replacement icon does <b>not</b> require a mask.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_INVALID_SOURCE = "IMG_OBJS_DND_INVALID_SOURCE"; //$NON-NLS-1$
/**
* Cursor 'mask' for the 'no drop' arrow cursor. For cursor construction see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated No longer needed with {@link #IMG_OBJS_DND_INVALID}.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_INVALID_MASK = "IMG_OBJS_DND_INVALID_MASK"; //$NON-NLS-1$

/**
* Cursor 'source' for the 'in stack' arrow cursor. For cursor construction see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated Dropped in favor of {@link #IMG_OBJS_DND_STACK}. The replacement
* icon does <b>not</b> require a mask.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_STACK_SOURCE = "IMG_OBJS_DND_STACK_SOURCE"; //$NON-NLS-1$
/**
* Cursor 'mask' for the 'in stack' arrow cursor. For cursor construction see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated No longer needed with {@link #IMG_OBJS_DND_STACK}.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_STACK_MASK = "IMG_OBJS_DND_STACK_MASK"; //$NON-NLS-1$

/**
* Cursor 'source' for the 'off-screen' (detached window) arrow cursor. For
* cursor construction see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated Dropped in favor of {@link #IMG_OBJS_DND_OFFSCREEN}. The
* replacement icon does <b>not</b> require a mask.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_OFFSCREEN_SOURCE = "IMG_OBJS_DND_OFFSCREEN_SOURCE"; //$NON-NLS-1$
/**
* Cursor 'mask' for the 'off-screen' (detached window) arrow cursor. For cursor
* construction see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated No longer needed with {@link #IMG_OBJS_DND_OFFSCREEN}.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_OFFSCREEN_MASK = "IMG_OBJS_DND_OFFSCREEN_MASK"; //$NON-NLS-1$

/**
* Cursor 'source' for the 'fast-view' arrow cursor. For cursor construction
* see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated Dropped in favor of {@link #IMG_OBJS_DND_TOFASTVIEW}. The
* replacement icon does <b>not</b> require a mask.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_TOFASTVIEW_SOURCE = "IMG_OBJS_DND_TOFASTVIEW_SOURCE"; //$NON-NLS-1$
/**
* Cursor 'mask' for the 'fast-view' arrow cursor. For cursor construction see:
*
* @see Cursor#Cursor(Device, ImageData, ImageData, int, int)
* @since 3.5
* @deprecated No longer needed with {@link #IMG_OBJS_DND_TOFASTVIEW}.
* @noreference Marked for deletion since newer versions are available; see
* https://github.com/eclipse-platform/eclipse.platform.ui/pull/2084
*/
@Deprecated(forRemoval = true, since = "2024-09")
String IMG_OBJS_DND_TOFASTVIEW_MASK = "IMG_OBJS_DND_TOFASTVIEW_MASK"; //$NON-NLS-1$

// The following set of constants represent the images that are used to
// construct cursors for drag and drop operations within the workbench.
// The hotspot of those cursors is the center of the image, which needs to be
// calculated dynamically w.r.t. the current device zoom:
// descriptor = getImageDescriptor(id);
// cursor = new Cursor(display, descriptor.getImageData(100), 16, 16);
// cursor = new Cursor(display, descriptor.getImageData(200), 32, 32);

/**
* Identifies the lef arrow cursor. For cursor construction see:
*
Expand Down
17 changes: 0 additions & 17 deletions bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/WorkbenchImages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ private static final void declareImage(String key, String disabledKey, String pa
* Declares all the workbench's images, including both "shared" ones and
* internal ones.
*/
@SuppressWarnings("removal")
private static final void declareImages() {
declareImage(ISharedImages.IMG_DEF_MISSING, ImageDescriptor.getMissingImageDescriptor(), true);

Expand Down Expand Up @@ -263,22 +262,6 @@ private static final void declareImages() {
declareImage(ISharedImages.IMG_OBJS_WARN_TSK, PATH_OBJECT + "warn_tsk.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_INFO_TSK, PATH_OBJECT + "info_tsk.svg", true); //$NON-NLS-1$

declareImage(ISharedImages.IMG_OBJS_DND_LEFT_SOURCE, PATH_POINTER + "left_source.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_LEFT_MASK, PATH_POINTER + "left_mask.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_RIGHT_SOURCE, PATH_POINTER + "right_source.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_RIGHT_MASK, PATH_POINTER + "right_mask.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_TOP_SOURCE, PATH_POINTER + "top_source.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_TOP_MASK, PATH_POINTER + "top_mask.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_BOTTOM_SOURCE, PATH_POINTER + "bottom_source.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_BOTTOM_MASK, PATH_POINTER + "bottom_mask.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_INVALID_SOURCE, PATH_POINTER + "invalid_source.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_INVALID_MASK, PATH_POINTER + "invalid_mask.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_STACK_SOURCE, PATH_POINTER + "stack_source.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_STACK_MASK, PATH_POINTER + "stack_mask.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_OFFSCREEN_SOURCE, PATH_POINTER + "offscreen_source.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_OFFSCREEN_MASK, PATH_POINTER + "offscreen_mask.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_TOFASTVIEW_SOURCE, PATH_POINTER + "tofastview_source.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_TOFASTVIEW_MASK, PATH_POINTER + "tofastview_mask.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_LEFT, PATH_POINTER + "left.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_RIGHT, PATH_POINTER + "right.svg", true); //$NON-NLS-1$
declareImage(ISharedImages.IMG_OBJS_DND_TOP, PATH_POINTER + "top.svg", true); //$NON-NLS-1$
Expand Down
23 changes: 0 additions & 23 deletions bundles/org.eclipse.ui/icons/full/pointer/bottom_mask.svg
View file
Open in desktop

This file was deleted.

Loading
Loading