Skip to content

Clean Code for debug/org.eclipse.debug.examples.core#2687

Closed
eclipse-platform-bot wants to merge 0 commit into
masterfrom
clean-code/debug/org.eclipse.debug.examples.core
Closed

Clean Code for debug/org.eclipse.debug.examples.core#2687
eclipse-platform-bot wants to merge 0 commit into
masterfrom
clean-code/debug/org.eclipse.debug.examples.core

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

eclipse-platform-bot commented Jun 2, 2026

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

debug/org.eclipse.debug.examples.core/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From b3a7c07f60b8db7e9a2112efa1307609a57e987d Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Fri, 5 Jun 2026 03:42:29 +0000
Subject: [PATCH] Version bump(s) for 4.41 stream


diff --git a/debug/org.eclipse.debug.examples.core/META-INF/MANIFEST.MF b/debug/org.eclipse.debug.examples.core/META-INF/MANIFEST.MF
index 2b3e7385fe..0c68867c3b 100644
--- a/debug/org.eclipse.debug.examples.core/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.debug.examples.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.debug.examples.core;singleton:=true
-Bundle-Version: 1.6.700.qualifier
+Bundle-Version: 1.6.800.qualifier
 Bundle-Activator: org.eclipse.debug.examples.core.pda.DebugCorePlugin
 Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.debug.core;bundle-version="3.9.0"
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Test Results

    54 files  ±0      54 suites  ±0   36m 48s ⏱️ -10s
 4 671 tests ±0   4 649 ✅ ±0   22 💤 ±0  0 ❌ ±0 
11 907 runs  ±0  11 754 ✅ ±0  153 💤 ±0  0 ❌ ±0 

Results for commit 13f43f6. ± Comparison against base commit a0b74bc.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/debug/org.eclipse.debug.examples.core branch from 51f5f81 to 6ea1e24 Compare June 3, 2026 03:42
org.eclipse.core.resources,
org.eclipse.core.variables;bundle-version="3.2.800",
org.eclipse.debug.core;bundle-version="3.9.0",
org.apache.ant;bundle-version="1.9.2";resolution:=optional
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the other PR ant is not removed in the IDE ...

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/debug/org.eclipse.debug.examples.core branch 2 times, most recently from f34c665 to 5f9fda7 Compare June 5, 2026 03:38
akurtakov added a commit to akurtakov/eclipse.platform that referenced this pull request Jun 5, 2026
Having a preprocessor written in ant to be able to drive a tutorial step
by step is total overkill and not helpful in this example.
Initiated by
eclipse-platform#2687 failure.
akurtakov added a commit that referenced this pull request Jun 5, 2026
Having a preprocessor written in ant to be able to drive a tutorial step
by step is total overkill and not helpful in this example.
Initiated by
#2687 failure.
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/debug/org.eclipse.debug.examples.core branch from 13f43f6 to 109f088 Compare June 5, 2026 11:18
@eclipse-platform-bot eclipse-platform-bot deleted the clean-code/debug/org.eclipse.debug.examples.core branch June 5, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants