Skip to content

Fix javadoc problems. #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 2 commits into from
Jun 5, 2026
+8 −15
Merged

Fix javadoc problems. #2716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50d0e69
Fix javadoc problems.
akurtakov Jun 5, 2026
6ca47e6
Fail the build on javadoc error
akurtakov Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions ....tests.ui/External Tools/org/eclipse/ant/tests/ui/externaltools/ExternalToolTestUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2011, 2013 IBM Corporation and others.
* Copyright (c) 2011, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -31,13 +31,6 @@
import org.eclipse.debug.core.ILaunchConfigurationWorkingCopy;
import org.eclipse.ui.externaltools.internal.model.BuilderUtils;

import junit.framework.Test;

/**
* Abstract {@link Test} class for external tools
*
* @since 3.5.100 org.eclipse.ant.tests.ui
*/
@SuppressWarnings("restriction")
public final class ExternalToolTestUtil {

Expand Down
13 changes: 6 additions & 7 deletions debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/TestUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2017 Google, Inc and others.
* Copyright (c) 2017, 2026 Google, Inc and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand All @@ -24,8 +24,6 @@
import java.util.List;
import java.util.Set;
import java.util.function.BooleanSupplier;
import java.util.function.Function;
import java.util.function.Predicate;
import java.util.function.Supplier;

import org.eclipse.core.internal.jobs.JobManager;
Expand Down Expand Up @@ -125,8 +123,8 @@ public static void processUIEvents(final long millis) throws Exception {
/**
* Waits while given condition is {@code true} for a given amount of
* milliseconds. If the actual wait time exceeds given timeout and condition
* will be still {@code true}, throws {@link junit.framework.AssertionError}
* with given message.
* will be still {@code true}, throws AssertionFailedError with given
* message.
* <p>
* Will process UI events while waiting in UI thread, if called from
* background thread, just waits.
Expand Down Expand Up @@ -163,6 +161,7 @@ public static void waitWhile(BooleanSupplier condition, long timeout, Supplier<S
* <p>
* Will process UI events while waiting in UI thread, if called from
* background thread, just waits.
* </p>
*
* @param condition function which will be evaluated while waiting
* @param errorMessage message which will be used to construct the failure
Expand All @@ -175,11 +174,11 @@ public static void waitWhile(BooleanSupplier condition, Supplier<String> errorMe

/**
* A simplified variant of
* {@link #waitWhile(Predicate, Object, long, Function)}.
* {@link #waitWhile(BooleanSupplier, long, Supplier)}.
* <p>
* Waits while given condition is {@code true} for a given amount of
* milliseconds.
* <p>
* </p>
* Will process UI events while waiting in UI thread, if called from
* background thread, just waits.
*
Expand Down
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
<properties>
<tycho.scmUrl>scm:git:https://github.com/eclipse-platform/eclipse.platform.git</tycho.scmUrl>
<tycho.surefire.testClassesDirectory>${project.build.outputDirectory}</tycho.surefire.testClassesDirectory>
<failOnJavadocErrors>true</failOnJavadocErrors>
</properties>

<!--
Expand Down
Loading