Add support for the Resume Other Threads operation.#2724
Open
SougandhS wants to merge 1 commit into
Open
Conversation
Contributor
|
That sounds cool! |
Contributor
Author
Thanks ! |
Member
|
I would not use same icon for this action as for "Resume", better no icon. |
Member
|
Would be good to have a test. |
Contributor
Author
Sure 👍 |
Contributor
Test Results 42 files - 12 42 suites - 12 24m 11s ⏱️ - 10m 3s Results for commit 8c36f3b. ± Comparison against base commit 4b2964a. This pull request removes 710 tests.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
This PR introduces a new debug command/action, “Resume Others”, intended to resume all suspended threads in the same debug target except the currently selected one, and wires it into the Debug UI (including a Shift+F8 key binding).
Changes:
- Added a new public core command handler interface (
IResumeOthersHandler) plus default implementation and adapter wiring in debug core. - Added corresponding Debug UI action/handler/delegate, contributed to the Debug view toolbar/context menu, and registered the command + key binding in
plugin.xml. - Added new UI strings for the action label.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/launch/LaunchView.java | Adds the new action to the Debug view toolbar and context menu. |
| debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/commands/actions/ResumeOthersCommandHandler.java | Adds UI command handler to support key binding execution. |
| debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/commands/actions/ResumeOthersCommandActionDelegate.java | Adds workbench action delegate wrapper for the command action. |
| debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/commands/actions/ResumeOthersCommandAction.java | Implements the UI action for “Resume Others”. |
| debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/ActionMessages.properties | Adds label text for the new action. |
| debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/actions/ActionMessages.java | Adds NLS field for the new action text. |
| debug/org.eclipse.debug.ui/plugin.xml | Registers the action contribution, command, and Shift+F8 key binding. |
| debug/org.eclipse.debug.ui/plugin.properties | Adds plugin-level strings for the new command/action. |
| debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/commands/ResumeOthersCommand.java | Implements core execution logic for resuming “other” threads. |
| debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/commands/CommandAdapterFactory.java | Wires up core adapter for IResumeOthersHandler. |
| debug/org.eclipse.debug.core/core/org/eclipse/debug/core/commands/IResumeOthersHandler.java | Adds the new public handler interface in debug core. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Introduces a new debug command handler and action that resumes all suspended threads in the same debug target except the selected thread. This allows developers to continue execution of other suspended threads while keeping the current thread suspended for inspection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
Resume Other Threadsaction to the Debug view, along with the keyboard shortcutShift+F8.The action resumes all suspended threads in the same debug target except the selected thread, allowing developers to continue execution of other threads while keeping the current thread suspended for inspection. Similar functionality is available in other IDEs, making multithreaded debugging workflows more convenient and efficient.
ThreadOthers.mp4