Skip to content

Show disabled icon for Disabled category in Breakpoint Enablement Grouping #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SougandhS wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −3
Open

Show disabled icon for Disabled category in Breakpoint Enablement Grouping #2729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...pse.debug.ui/ui/org/eclipse/debug/internal/ui/views/breakpoints/BreakpointEnablement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2025 IBM Corporation and others.
* Copyright (c) 2025, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand All @@ -23,8 +23,10 @@
import org.eclipse.debug.core.DebugPlugin;
import org.eclipse.debug.core.IBreakpointsListener;
import org.eclipse.debug.core.model.IBreakpoint;
import org.eclipse.debug.internal.ui.DebugPluginImages;
import org.eclipse.debug.ui.AbstractBreakpointOrganizerDelegate;
import org.eclipse.debug.ui.BreakpointTypeCategory;
import org.eclipse.debug.ui.IDebugUIConstants;

/**
* Breakpoint organizers for breakpoint types based on breakpoint enablement
Expand All @@ -33,7 +35,8 @@
public class BreakpointEnablement extends AbstractBreakpointOrganizerDelegate implements IBreakpointsListener {

private final BreakpointTypeCategory ENABLED = new BreakpointTypeCategory("Enabled", 0); //$NON-NLS-1$
private final BreakpointTypeCategory DISABLED = new BreakpointTypeCategory("Disabled", 1); //$NON-NLS-1$
private final BreakpointTypeCategory DISABLED = new BreakpointTypeCategory("Disabled", 1, //$NON-NLS-1$
DebugPluginImages.getImageDescriptor(IDebugUIConstants.IMG_OBJS_BREAKPOINT_GROUP_DISABLED));

private final Map<IBreakpoint, Boolean> breakpointCache;

Expand Down
20 changes: 19 additions & 1 deletion debug/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/BreakpointTypeCategory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2013 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -70,6 +70,24 @@ public BreakpointTypeCategory(String name, int sortPriority) {
fSortPriority = sortPriority;
}

/**
* Constructs a type category for the given type name, given sort and with the
* given image.
*
* @param name breakpoint type name
* @param sortPriority used to calculate the sort order of this category
* @param descriptor image descriptor
* @since 3.22
*/
public BreakpointTypeCategory(String name, int sortPriority, ImageDescriptor descriptor) {
fName = name;
fSortable = true;
fSortPriority = sortPriority;
if (descriptor != null) {
fImageDescriptor = descriptor;
}
}

/**
* Returns the name of this category's breakpoint type.
*
Expand Down
Loading