Use user accent for selection background#1722
Merged
Merged
Conversation
zeebok
approved these changes
May 24, 2026
Contributor
zeebok
left a comment
zeebok
left a comment
There was a problem hiding this comment.
Seems reasonable. I see 2 of the tests failed, kind of surprised by that.
Collaborator
Author
|
@zeebok Yes - its something to do with building the flatpak in CI though - pretty sure not caused by this PR anyway. I'll have a look into flatpak building locally but as it is not shipped as flatpak atm it is not critical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1289
The provided user accent colors contrast better with text and hightlight styles than the present hard-coded colors. Also the user has control over them and it improves consistency with selections elsewhere in the app and other apps.
Gtk already uses the accent color for selections by default so we just stop overriding it.