Run test_unistd_isatty under deno. NFC#26601
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 15, 2026
Merged
Conversation
The upstream issue has now been fixed: denoland/deno#32995
brendandahl
approved these changes
Apr 3, 2026
Collaborator
|
I guess this hasn't made it into the deno release yet? |
Collaborator
|
Haven't we disabled deno testing? Do we know if this fix made it into deno yet? |
Collaborator
|
Oh I see we ran |
Collaborator
Author
Ah.. yes, that as not deliberate.. But it worked because I did not rebase this branch so when i did "re-run all tests" it ran all the tests that were enabled when I created this branch. Lucky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream issue has now been fixed: denoland/deno#32995