Feature/517 release prepare report resolved security issues#797
Open
Feature/517 release prepare report resolved security issues#797
Conversation
(vulnerabilities currently commented-out, yet)
Fixed tests
added test for inserted vulnerabilities
ckunki
commented
Apr 20, 2026
ArBridgeman
reviewed
Apr 21, 2026
Co-authored-by: Ariel Schulz <43442541+ArBridgeman@users.noreply.github.com>
ArBridgeman
reviewed
Apr 21, 2026
| config = {**defaults, **kwargs} | ||
|
|
||
| return subprocess.run(command, **config) | ||
| p = subprocess.run(command, **config) |
Collaborator
There was a problem hiding this comment.
did you want check to not be updated with the **config? it seems like the logic in line 101 indicates that.
Contributor
Author
There was a problem hiding this comment.
I wanted to use check=False by default but still allow use cases to specify check=True.
But I agree, maybe the current impl. it not 100% correct.
ckunki
commented
Apr 21, 2026
| ] | ||
|
|
||
| [tool.poetry.requires-plugins] | ||
| poetry-plugin-export = ">=1.8" |
Contributor
Author
There was a problem hiding this comment.
Seems to be required to run poetry export in the integration tests.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #517
Checklist
Note: If any of the items in the checklist are not relevant to your PR, just check the box.
For any Pull Request
Is the following correct:
When Changes Were Made
Did you:
When Preparing a Release
Have you: