Add instrumentation tests for FabricMountingManager view lifecycle (#56294)#56294
Closed
javache wants to merge 1 commit intofacebook:mainfrom
Closed
Add instrumentation tests for FabricMountingManager view lifecycle (#56294)#56294javache wants to merge 1 commit intofacebook:mainfrom
javache wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
meta-codesync
bot
changed the title
javache
force-pushed
the
export-D98935855
branch
from
d2a7e7f to
c109e95
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 1, 2026
…acebook#56294) Summary: Add Android instrumentation tests that validate the Java-side and C++ registry behavior around view preallocation, destruction, and recreation — the core scenario fixed by D98729251. Two layers of tests: 1. **Java-side tests** (IntBufferBatchMountItem): Construct mount item int/obj buffers manually and execute against MountingManager. Validates CREATE→INSERT and Preallocate→Delete→CREATE→INSERT sequences through the Java mount system. 2. **Native registry tests** (FabricMountingManagerTestHelper): JNI hybrid class that creates a real C++ FabricMountingManager and exercises the allocatedViewRegistry_ lifecycle. Validates that after preallocate + destroy, the tag is removed from the registry (the D98729251 fix), so executeMount would correctly emit a CREATE instruction. The native test helper is built as a separate library (libfabricjni_test_helper.so) under jni/react/fabric/test/, with friend access to FabricMountingManager internals. Changelog: [Internal] Differential Revision: D98935855
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 1, 2026
…acebook#56294) Summary: Pull Request resolved: facebook#56294 Add Android instrumentation tests that validate the Java-side and C++ registry behavior around view preallocation, destruction, and recreation — the core scenario fixed by D98729251. Two layers of tests: 1. **Java-side tests** (IntBufferBatchMountItem): Construct mount item int/obj buffers manually and execute against MountingManager. Validates CREATE→INSERT and Preallocate→Delete→CREATE→INSERT sequences through the Java mount system. 2. **Native registry tests** (FabricMountingManagerTestHelper): JNI hybrid class that creates a real C++ FabricMountingManager and exercises the allocatedViewRegistry_ lifecycle. Validates that after preallocate + destroy, the tag is removed from the registry (the D98729251 fix), so executeMount would correctly emit a CREATE instruction. The native test helper is built as a separate library (libfabricjni_test_helper.so) under jni/react/fabric/test/, with friend access to FabricMountingManager internals. Changelog: [Internal] Differential Revision: D98935855
javache
force-pushed
the
export-D98935855
branch
2 times, most recently
from
43bf24a to
534d051
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 2, 2026
…acebook#56294) Summary: Add Android instrumentation tests that validate the Java-side and C++ registry behavior around view preallocation, destruction, and recreation — the core scenario fixed by D98729251. Two layers of tests: 1. **Java-side tests** (IntBufferBatchMountItem): Construct mount item int/obj buffers manually and execute against MountingManager. Validates CREATE→INSERT and Preallocate→Delete→CREATE→INSERT sequences through the Java mount system. 2. **Native registry tests** (FabricMountingManagerTestHelper): JNI hybrid class that creates a real C++ FabricMountingManager and exercises the allocatedViewRegistry_ lifecycle. Validates that after preallocate + destroy, the tag is removed from the registry (the D98729251 fix), so executeMount would correctly emit a CREATE instruction. The native test helper is built as a separate library (libfabricjni_test_helper.so) under jni/react/fabric/test/, with friend access to FabricMountingManager internals. Changelog: [Internal] Differential Revision: D98935855
…acebook#56294) Summary: Add Android instrumentation tests that validate the Java-side and C++ registry behavior around view preallocation, destruction, and recreation — the core scenario fixed by D98729251. Two layers of tests: 1. **Java-side tests** (IntBufferBatchMountItem): Construct mount item int/obj buffers manually and execute against MountingManager. Validates CREATE→INSERT and Preallocate→Delete→CREATE→INSERT sequences through the Java mount system. 2. **Native registry tests** (FabricMountingManagerTestHelper): JNI hybrid class that creates a real C++ FabricMountingManager and exercises the allocatedViewRegistry_ lifecycle. Validates that after preallocate + destroy, the tag is removed from the registry (the D98729251 fix), so executeMount would correctly emit a CREATE instruction. The native test helper is built as a separate library (libfabricjni_test_helper.so) under jni/react/fabric/test/, with friend access to FabricMountingManager internals. Changelog: [Internal] Reviewed By: Abbondanzo Differential Revision: D98935855
javache
force-pushed
the
export-D98935855
branch
from
534d051 to
a929689
Compare
|
This pull request has been merged in 37a1841. |
Collaborator
|
This pull request was successfully merged by @javache in 37a1841 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add Android instrumentation tests that validate the Java-side and C++ registry
behavior around view preallocation, destruction, and recreation — the core
scenario fixed by D98729251.
Two layers of tests:
Java-side tests (IntBufferBatchMountItem): Construct mount item int/obj
buffers manually and execute against MountingManager. Validates CREATE→INSERT
and Preallocate→Delete→CREATE→INSERT sequences through the Java mount system.
Native registry tests (FabricMountingManagerTestHelper): JNI hybrid class
that creates a real C++ FabricMountingManager and exercises the
allocatedViewRegistry_ lifecycle. Validates that after preallocate + destroy,
the tag is removed from the registry (the D98729251 fix), so executeMount
would correctly emit a CREATE instruction.
The native test helper is built as a separate library (libfabricjni_test_helper.so)
under jni/react/fabric/test/, with friend access to FabricMountingManager internals.
Changelog: [Internal]
Reviewed By: Abbondanzo
Differential Revision: D98935855