Remove members that reference excluded symbols (#56341)#56341
Closed
coado wants to merge 1 commit intofacebook:mainfrom
Closed
Remove members that reference excluded symbols (#56341)#56341coado wants to merge 1 commit intofacebook:mainfrom
coado wants to merge 1 commit intofacebook:mainfrom
Conversation
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 7, 2026
Summary: Pull Request resolved: facebook#56341 Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Differential Revision: D99434605
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 7, 2026
Summary: Pull Request resolved: facebook#56341 Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Differential Revision: D99434605
aeedaa5 to
7fc2655
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 8, 2026
Summary: Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99434605
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 8, 2026
Summary: Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99434605
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 8, 2026
Summary: Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99434605
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 8, 2026
Summary: Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99434605
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 8, 2026
Summary: Pull Request resolved: facebook#56341 Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99434605
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 8, 2026
Summary: Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99434605
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 8, 2026
Summary: Pull Request resolved: facebook#56341 Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99434605
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 8, 2026
Summary: Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99434605
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 8, 2026
Summary: Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99434605
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 8, 2026
Summary: Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99434605
coado
added a commit
to coado/react-native
that referenced
this pull request
Apr 8, 2026
Summary: Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99434605
Summary: Pull Request resolved: facebook#56341 Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99434605
Collaborator
|
This pull request was successfully merged by @coado in 8bf151f When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g.,
facebook::yoga::ExperimentalFeature) to appear in the snapshot.Changelog:
[Internal]
Reviewed By: huntie
Differential Revision: D99434605