Skip to content

chore: Remove dead-code from Alert module#56342

Closed
retyui wants to merge 1 commit intofacebook:mainfrom
retyui:better-alert-module
Closed

chore: Remove dead-code from Alert module#56342
retyui wants to merge 1 commit intofacebook:mainfrom
retyui:better-alert-module

Conversation

@retyui
Copy link
Copy Markdown
Contributor

@retyui retyui commented Apr 7, 2026

Summary:

Code elimination won't be able to remove dead-code in if conditions that's always false, as Platfrom.OS === 'ios' is a runtime check

Screenshot 2026-04-07 at 13 39 06

Changelog:

[GENERAL] [CHANGED] - Separate an Alert implementation per platforms to remove dead-code

Test Plan:

// Run app and do
Alert.alert(...);
Alert.prompt(...); // ios only

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2026
@facebook-github-tools facebook-github-tools bot added p: Callstack Partner: Callstack Partner labels Apr 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Warning

JavaScript API change detected

This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API.

  • Please include a clear changelog message.
  • This change will be subject to additional review.

This change was flagged as: POTENTIALLY_BREAKING

@facebook-github-tools facebook-github-tools bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 7, 2026
@retyui retyui force-pushed the better-alert-module branch from 252db66 to c246009 Compare April 7, 2026 12:21
@retyui retyui closed this Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant