Exclude symbols with DO_NOT_USE from the public C++ API snapshot#56346
Open
coado wants to merge 3 commits intofacebook:mainfrom
Open
Exclude symbols with DO_NOT_USE from the public C++ API snapshot#56346coado wants to merge 3 commits intofacebook:mainfrom
DO_NOT_USE from the public C++ API snapshot#56346coado wants to merge 3 commits intofacebook:mainfrom
Conversation
Differential Revision: D99417803
Summary: Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Differential Revision: D99434605
Summary: Excludes all symbols and members that consists of `DO_NOT_USE`, like - findComponentViewWithTag_DO_NOT_USE_DEPRECATED - propKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN - setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN - findComponentDescriptorByHandle_DO_NOT_USE_THIS_IS_BROKEN - componentViewName_DO_NOT_USE_THIS_IS_BROKEN - ensurePlaceholderIfEmpty_DO_NOT_USE Changelog: [Internal] Differential Revision: D99834673
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
p: Software Mansion
cortinico
approved these changes
Apr 7, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Excludes all symbols and members that consists of
DO_NOT_USE, likeChangelog:
[Internal]
Differential Revision: D99834673