Support PlatformColor for StatusBar backgroundColor on Android#56540
Open
qflen wants to merge 1 commit into
Open
Support PlatformColor for StatusBar backgroundColor on Android#56540qflen wants to merge 1 commit into
qflen wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
qflen
force-pushed
the
fix/statusbar-platformcolor-48402
branch
2 times, most recently
from
bcd35d0 to
fe10146
Compare
Passing a PlatformColor to StatusBar.backgroundColor previously tripped an invariant in _updatePropsStack because processColor returns an object for PlatformColor and the native setColor TurboModule only accepted a number. Adds a setColorObject TurboModule method that accepts a resource-paths object and resolves it on the native side via ColorPropConverter.getColor. StatusBar.js now dispatches to setColor for numeric colors and to setColorObject for PlatformColor values. Fixes facebook#48402
qflen
force-pushed
the
fix/statusbar-platformcolor-48402
branch
from
fe10146 to
c7982b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #48402.
Passing a
PlatformColor(...)value toStatusBar.backgroundColoron Android currently throwsUnexpected color given in StatusBar._updatePropsStack.The failure happens because
processColorreturns an object forPlatformColor, while theStatusBarTurboModule only accepts numeric colors throughsetColor.This change adds a
setColorObjectTurboModule method that accepts a{resource_paths: Array<string>}payload and resolves it natively viaColorPropConverter.getColor.StatusBar._updatePropsStacknow dispatches to:setColorfor numeric colorssetColorObjectforPlatformColorvaluesTo avoid duplicating behavior, the shared animation and color-application logic is moved into a private
applyStatusBarColorhelper.Changelog:
[Android] [Fixed] - Allow
PlatformColorvalues to be used withStatusBar.backgroundColorTest Plan
yarn jest packages/react-native/Libraries/Components/StatusBaryarn flow focus-checkonStatusBar.jsand the specyarn eslintyarn prettier --check