React DOM: Add support for Invoker Commands API#36493
Open
MaxwellCohen wants to merge 2 commits into
Open
Conversation
This commit adds a new test case to verify that the commandFor attribute is correctly set on button elements. It ensures that the attribute is rendered as expected in the DOM. Additionally, it modifies the handling of the commandFor property in the ReactDOMComponent to allow for better error handling in development mode.
MaxwellCohen
commented
May 21, 2026
| document.body.removeChild(element); | ||
| } | ||
| }, | ||
| overrideStringValue: 'popover-target', |
Author
There was a problem hiding this comment.
I am reusing 'popover-target' ID be because the common use case for the invoker API is popovers. If I should change it let me know.
Author
|
@eps1lon or @rickhanlonii, this is ready for review. If you would be so kind, could you take a look at this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This includes support for commandfor, command, and oncommand event. The events are only triggered by elements that match the invoker command API.
The Invoker Commands API is currently supported in all major browsers (Chrome, Safari, Firefox)
I designed this PR to match React DOM: Add support for Popover API #27981 as closely as possible, with as few changes as possible.
fixes: #32478
How did you test this change?
Open Questions/Concerns
I leverage Composer 2.5 LLM to help me create this PR and reviewed every line