Conversation
| def downgrade(): | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.drop_constraint(None, 'item', type_='foreignkey') | ||
| op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey') |
There was a problem hiding this comment.
A little confused about this one, as drop_constraint requires a str constraint name. Not sure why it was None before and I don't see how it would have worked. Feels like this is an actual bug fix? 🤔
There was a problem hiding this comment.
I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
@alejsdev : by bumping to ty 0.0.25, we're able to have less ignore statements when combining mypy with ty, cf this edit. So I think that's nice! I also changed the settings to error on warning, as discussed with Sebastián - we'll do this for all our repos. So this should be in a good state to review/merge (again) now 🙏
| def downgrade(): | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.drop_constraint(None, 'item', type_='foreignkey') | ||
| op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey') |
There was a problem hiding this comment.
I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️
3 participants
tyto pyproject, lint.sh & precommittyhappy