Highlight matched nodes in the stack chart when searching#5935
Open
fatadel wants to merge 1 commit intofirefox-devtools:mainfrom
Open
Highlight matched nodes in the stack chart when searching#5935fatadel wants to merge 1 commit intofirefox-devtools:mainfrom
fatadel wants to merge 1 commit intofirefox-devtools:mainfrom
Conversation
When a search string is active, draw a BLUE_60 border around stack chart boxes whose function name matches. Ancestor call nodes in the path of a match also get a thinner border to highlight the full call node path.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5935 +/- ##
==========================================
+ Coverage 85.45% 85.46% +0.01%
==========================================
Files 321 321
Lines 32139 32171 +32
Branches 8850 8775 -75
==========================================
+ Hits 27463 27495 +32
Misses 4241 4241
Partials 435 435 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Looks acceptable to me visually. Not super pretty but good enough :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1818.
When a search string is active, draw a BLUE_60 border around stack chart boxes whose function name matches. Ancestor call nodes in the path of a match also get a thinner border to highlight the full call node path.
Before reviewing the code changes, I would like you to have a look visually and tell me if that is what you want to see 🤓
This is the profile from the STR of the original issue with the changes of this PR.