More additions to profiler-edit, for sp3 profiles#6009
Open
mstange wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6009 +/- ##
==========================================
- Coverage 83.69% 83.37% -0.32%
==========================================
Files 338 338
Lines 35693 35846 +153
Branches 9904 9940 +36
==========================================
+ Hits 29873 29887 +14
- Misses 5392 5531 +139
Partials 428 428 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fd67c9e to
f5ac119
Compare
f5ac119 to
33ec551
Compare
33ec551 to
508ee02
Compare
508ee02 to
9d9f405
Compare
9d9f405 to
e496d7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that you can run profiler-edit with
--insert-label-frames browser_labels.toml --only-keep-threads-with-markers-matching='-async,-sync' --merge-non-overlapping-threads-by-name --set-name 'Sp3 5x (with labels, combined main threads)'to turn https://share.firefox.dev/4cXQFED into https://share.firefox.dev/4ezEcsaThe label frames are useful in the JS-only view when applied to profiles from samply; they let us group work like "Paint" and "JS Parsing" (example toml). You can best see them in action in the function list deploy preview: JS-only, ordered by self, with the Self wing showing where the time is spent.