Expose counter information in profiler-cli#6084
Open
fatadel wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6084 +/- ##
==========================================
- Coverage 83.82% 83.43% -0.39%
==========================================
Files 330 339 +9
Lines 34682 35690 +1008
Branches 9703 10017 +314
==========================================
+ Hits 29072 29779 +707
- Misses 5181 5483 +302
+ Partials 429 428 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
|
Add `counter list` and `counter info <handle>` commands, and list each counter under its process in `profile info`, to inspect any counter track from the terminal. Counters get stable `c-N` handles, like threads and functions. Per-counter stats come from the counter's own tooltip schema, reusing the timeline tooltips' labels and formatters so the CLI and UI agree. Stats respect the current zoom. Part of firefox-devtools#6040
Contributor
Author
|
@canova makes sense, updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
counter listandcounter info <handle>commands, and list each counter under its process inprofile info, to inspect any counter track from the terminal. Counters get stablec-Nhandles, like threads and functions.Per-counter stats come from the counter's own tooltip schema, reusing the timeline tooltips' labels and formatters so the CLI and UI agree. Stats respect the current zoom.
This is only the first iteration for #6040.
Usage examples