Conversation
Fix getting started flow ``` run-evals \ --task question_answer \ --model google/gemini-2.5-flash \ --dataset ./my_first_sample.json ```
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the task initialization logic within the argument runner to ensure consistent naming conventions for task definitions, facilitating a smoother execution flow for evaluation tasks. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the task_def dictionary key from name to task_name in the arguments runner. Feedback suggests also including the sandbox_type in this dictionary when specified via CLI arguments to prevent validation errors for tasks requiring specific sandbox environments.
|
|
||
| # Build the task instance | ||
| task_def = {"name": args.task} | ||
| task_def = {"task_name": args.task} |
There was a problem hiding this comment.
While updating the key to task_name is correct, this dictionary should also include sandbox_type when a sandbox is specified via CLI arguments. Without sandbox_type, task-level validation (such as in validate_sandbox_tools) will default to assuming a local sandbox, which can cause incorrect failures for tasks that require a Linux container (e.g., those using bash_session or text_editor) even when the user has provided a valid sandbox configuration via the --sandbox flag.
| task_def = {"task_name": args.task} | |
| task_def = {"task_name": args.task} | |
| if args.sandbox: | |
| task_def["sandbox_type"] = args.sandbox[0] |
Fix getting started flow
which fails with:
Issue Link:
What is the link to the issue this cherry-pick is addressing?
https://github.com/flutter/flutter/issues/< Replace with issue link here >