Using medium font size, rather than large#13232
Merged
Conversation
Collaborator
|
Visit the preview URL for this PR (updated for commit 2813304): https://flutter-docs-prod--pr13232-fix-orientation-font-zobbpsm0.web.app |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the text styles from displayLarge to headlineLarge across the orientation cookbook example and its documentation, while also refining Markdown formatting. The reviewer identified a critical issue where TextTheme.of(context) is used incorrectly, as TextTheme does not have a static of method; the correct approach is Theme.of(context).textTheme. It was also suggested to consider headlineMedium to better align with the PR's objective of using a medium font size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13187