Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Android deployment documentation by refining terminology, updating link references, and adding instructions for updating the application ID and namespace. The review feedback identifies a broken Markdown link reference caused by a label mismatch and suggests expanding the application ID update example to include Java file paths for better completeness.
| [flutter_launcher_icons]: {{site.pub}}/packages/flutter_launcher_icons | ||
| [launchericons]: {{site.material}}/styles/icons | ||
| [configuration qualifiers]: {{site.android-dev}}/guide/topics/resources/providing-resources#AlternativeResources | ||
| [config qual]: {{site.android-dev}}/guide/topics/resources/providing-resources#AlternativeResources |
There was a problem hiding this comment.
The link reference label [config qual] does not match the identifier [config-qual] used on line 50. Markdown link references must match exactly (including spaces and hyphens) to resolve correctly.
| [config qual]: {{site.android-dev}}/guide/topics/resources/providing-resources#AlternativeResources | |
| [config-qual]: {{site.android-dev}}/guide/topics/resources/providing-resources#AlternativeResources |
| For example, if your new ID is `com.example.myapp`, | ||
| move your `MainActivity` file to | ||
| `android/app/src/main/kotlin/com/example/myapp/MainActivity.kt` | ||
| and ensure the first line is `package com.example.myapp`. |
There was a problem hiding this comment.
Since the instructions mention both Kotlin and Java files, it's helpful to provide the example path for both languages to ensure clarity for all users.
| For example, if your new ID is `com.example.myapp`, | |
| move your `MainActivity` file to | |
| `android/app/src/main/kotlin/com/example/myapp/MainActivity.kt` | |
| and ensure the first line is `package com.example.myapp`. | |
| For example, if your new ID is com.example.myapp, | |
| move your MainActivity file to | |
| android/app/src/main/kotlin/com/example/myapp/MainActivity.kt | |
| (or android/app/src/main/java/com/example/myapp/MainActivity.java) | |
| and ensure the first line is package com.example.myapp. |
|
Visit the preview URL for this PR (updated for commit 83dc2ca): https://flutter-docs-prod--pr13242-fix-12137-b6100ycj.web.app |
Fixes #12137