Add breaking change notice for OpenGL ES render-to-texture orientation#13419
Add breaking change notice for OpenGL ES render-to-texture orientation#13419bdero wants to merge 1 commit into
Conversation
|
Staged preview of the updated docs.flutter.dev site (updated for commit dd7d1d2): https://flutter-docs-prod--docs-pr13419-bdero-breaking-change-bys51mj7.web.app |
There was a problem hiding this comment.
Code Review
This pull request documents a breaking change where Impeller's OpenGL ES backend now stores render-to-texture content top-down, aligning it with Metal and Vulkan. It includes a new breaking change document and updates the index. I have no feedback to provide.
gaaclarke
left a comment
There was a problem hiding this comment.
This is worded too specifically for Flutter GPU, it has broader impact.
| top-down, matching Metal and Vulkan, which can affect Flutter GPU | ||
| apps that compensated for the previous bottom-up orientation. |
There was a problem hiding this comment.
This needs to be updated to reflect that it affects Flutter users using the FragmentShader API, not just Flutter GPU users.
| Code before migration: | ||
|
|
||
| ```glsl | ||
| // The flip only compensated for OpenGL ES's bottom-up render targets. |
There was a problem hiding this comment.
Let's include the whole preprocessor conditional compilation so people have a better idea of what they'll be looking for.
Description of what this PR is changing or adding, and why:
Adds a breaking change notice for the Impeller OpenGL ES change in flutter/flutter#186556, which stores render-to-texture content top-down to match Metal and Vulkan. The only surface that can observe the old orientation is the experimental Flutter GPU API, so this is a courtesy notice rather than a hard breaking change.
Issues fixed by this PR (if any):
None.
PRs or commits this PR depends on (if any):
flutter/flutter#186556. The Timeline version is a placeholder until that engine PR lands and the release is known.
Presubmit checklist