refactor(share_plus): change android gradle from groovy to kotlin#3860
Open
mdmahendri wants to merge 1 commit into
Open
refactor(share_plus): change android gradle from groovy to kotlin#3860mdmahendri wants to merge 1 commit into
mdmahendri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the
share_plusbuild configuration from Groovy to Kotlin DSL, aligning with the standard detailed in #3858.this PR adds a subproject check to only redirect build directories for local subprojects:
subprojects { val isLocalProject = project.projectDir.canonicalPath.startsWith(rootProject.projectDir.canonicalPath) if (isLocalProject) { val newSubProjectBuildDir: Directory = newBuildDir.dir(project.name) project.layout.buildDirectory.value(newSubProjectBuildDir) } }This is needed to resolve bug described in Android build fails with certain plugins if project is in a different drive (from sdk) flutter/flutter#105395 and safely prevents Windows "different roots" Gradle build errors thrown by plugins like
file_selector_androidwhen the host project and the Flutter Pub cache reside on different logical drives (e.g., D: vs C:). This way, contributors using Windows won't encounter the same problem again.