Skip to content

ref(samples): [Queue Instrumentation 18] Move Kafka sources into queues.kafka package#5313

Draft
adinauer wants to merge 1 commit intofeat/queue-instrumentation-kafka-consumer-tracingfrom
ref/queue-instrumentation-kafka-sample-package
Draft

ref(samples): [Queue Instrumentation 18] Move Kafka sources into queues.kafka package#5313
adinauer wants to merge 1 commit intofeat/queue-instrumentation-kafka-consumer-tracingfrom
ref/queue-instrumentation-kafka-sample-package

Conversation

@adinauer
Copy link
Copy Markdown
Member

@adinauer adinauer commented Apr 21, 2026

PR Stack (Queue Instrumentation)


📜 Description

Move KafkaConsumer and KafkaController in the three Spring Boot Jakarta samples (sentry-samples-spring-boot-jakarta, sentry-samples-spring-boot-jakarta-opentelemetry, sentry-samples-spring-boot-jakarta-opentelemetry-noagent) into a queues.kafka sub-package.

No behavior change. Only the package declaration and file location change.

💡 Motivation and Context

Groups the Kafka-specific sample sources under a dedicated sub-package so future queue integrations can sit next to them under queues. Keeps the top-level sample package from accumulating integration-specific classes.

💚 How did you test it?

  • ./gradlew :sentry-samples:sentry-samples-spring-boot-jakarta:compileJava :sentry-samples:sentry-samples-spring-boot-jakarta-opentelemetry:compileJava :sentry-samples:sentry-samples-spring-boot-jakarta-opentelemetry-noagent:compileJava — all compile
  • ./gradlew spotlessApply apiDump

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Continue on top of this branch for the next PR in the Queue Instrumentation stack.

#skip-changelog

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

…es.kafka package

Move KafkaConsumer and KafkaController in the three Spring Boot Jakarta
samples (jakarta, jakarta-opentelemetry, jakarta-opentelemetry-noagent)
into a queues.kafka sub-package.

No behavior change. Groups the Kafka-specific sample sources so future
queue integrations can sit next to them under queues.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 21, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

This was referenced Apr 21, 2026
@sentry
Copy link
Copy Markdown

sentry bot commented Apr 21, 2026

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.37.1 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions
Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 284.02 ms 375.28 ms 91.26 ms
Size 0 B 0 B 0 B

Baseline results on branch: feat/queue-instrumentation-kafka-consumer-tracing

Startup times

Revision Plain With Sentry Diff
c55bfb9 325.59 ms 387.87 ms 62.29 ms
14a9178 316.11 ms 341.69 ms 25.59 ms

App size

Revision Plain With Sentry Diff
c55bfb9 0 B 0 B 0 B
14a9178 0 B 0 B 0 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant