ref: Remove Python 2 compat from qualname_from_function#6137
Merged
ericapisani merged 4 commits intomasterfrom Apr 27, 2026
Merged
ref: Remove Python 2 compat from qualname_from_function#6137ericapisani merged 4 commits intomasterfrom
ericapisani merged 4 commits intomasterfrom
Conversation
The SDK requires Python ≥ 3.6, so the `im_class` try/except and the `__name__` fallback annotated "Python 2.7 has no __qualname__" can never fire. Dropping them also removes a broad `except Exception: pass` that could mask real bugs in the happy path. No behavior change for any Python 3 input; return contract is preserved for callers in `tracing_utils.py`, `integrations/ray.py`, `integrations/asgi.py`, and `integrations/django/tasks.py`. Refs PY-2298 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Codecov Results 📊✅ 14 passed | Total: 14 | Pass Rate: 100% | Execution Time: 3.21s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 15927 uncovered lines. Files with missing lines (1)
Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6d4e045. Configure here.
sentrivana
approved these changes
Apr 27, 2026
alexander-alderman-webb
requested changes
Apr 27, 2026
Contributor
alexander-alderman-webb
left a comment
alexander-alderman-webb
left a comment
There was a problem hiding this comment.
Requesting changes for #6137 (comment)
…have a defined, or C extension functions which only have return a value
…at may not have a `__qualname__` defined, or C extension functions which only have `__name__` return a value Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…:getsentry/sentry-python into py-2298-remove-python2-compat-code-cg9li
alexander-alderman-webb
approved these changes
Apr 27, 2026
Contributor
alexander-alderman-webb
left a comment
alexander-alderman-webb
left a comment
There was a problem hiding this comment.
Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove two Python 2 compatibility branches from
sentry_sdk/utils.py::qualname_from_functionthat can never fire.The SDK requires Python ≥ 3.6 (
setup.py), so theim_classtry/except(Python 2 bound-method attribute) and theelif hasattr(func, "__name__")fallback annotated# Python 2.7 has no __qualname__are dead code.No behavior change for any Python 3 input — the return contract is preserved for callers in
tracing_utils.py,integrations/ray.py,integrations/asgi.py, andintegrations/django/tasks.py.Refs PY-2298