feat(tornado): Support span streaming#6206
Merged
Merged
Conversation
sl0thentr0py
changed the title
Contributor
Codecov Results 📊✅ 282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 43.61s All tests are passing successfully. ❌ Patch coverage is 19.12%. Project has 14835 uncovered lines. Files with missing lines (2)
Generated by Codecov Action |
sl0thentr0py
changed the title
alexander-alderman-webb
approved these changes
May 6, 2026
Contributor
alexander-alderman-webb
left a comment
alexander-alderman-webb
left a comment
There was a problem hiding this comment.
Comment not blocking, looks good to me!
sentrivana
reviewed
May 6, 2026
ericapisani
reviewed
May 6, 2026
sentrivana
reviewed
May 7, 2026
sl0thentr0py
force-pushed
the
neel/span-first/tornado
branch
from
82de412 to
a58538d
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sl0thentr0py
force-pushed
the
neel/span-first/tornado
branch
from
036b60a to
4f36419
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
sl0thentr0py
force-pushed
the
neel/span-first/tornado
branch
3 times, most recently
from
4d430e9 to
2106ec2
Compare
sl0thentr0py
force-pushed
the
neel/span-first/tornado
branch
3 times, most recently
from
e390c87 to
ec6fd01
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1fa438a. Configure here.
sl0thentr0py
force-pushed
the
neel/span-first/tornado
branch
from
4d4e44e to
4c597a4
Compare
ericapisani
reviewed
May 15, 2026
| def test_transactions(tornado_testcase, sentry_init, capture_events, handler, code): | ||
| sentry_init(integrations=[TornadoIntegration()], traces_sample_rate=1.0) | ||
| events = capture_events() | ||
| def test_transactions( |
Member
There was a problem hiding this comment.
Since this is now testing both segments and transactions, this test name should be updated
Member
Author
There was a problem hiding this comment.
what should I update it to instead? I took wsgi tests as a reference and they're still called transactions
Add span-streaming support to the Tornado integration. When span streaming is enabled, the request handler emits a StreamedSpan with HTTP request attributes (method, headers, query, URL, client address) and sets the response status on completion. The legacy transaction path is preserved for non-streaming mode. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
sl0thentr0py
force-pushed
the
neel/span-first/tornado
branch
from
4c597a4 to
ee5bfee
Compare
sl0thentr0py
force-pushed
the
neel/span-first/tornado
branch
from
f76454c to
ef0a5f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues