Skip to content

test(starlette): Verify request info captured with POST endpoints#6269

Open
alexander-alderman-webb wants to merge 4 commits into
masterfrom
webb/starlette/request-extractor-tests
Open

test(starlette): Verify request info captured with POST endpoints#6269
alexander-alderman-webb wants to merge 4 commits into
masterfrom
webb/starlette/request-extractor-tests

Conversation

@alexander-alderman-webb
Copy link
Copy Markdown
Contributor

@alexander-alderman-webb alexander-alderman-webb commented May 15, 2026

Description

Replace tests that directly call StarletteRequestExtractor with tests that assert that request info is captured on errors and transaction events when appropriate POST endpoints are called.

Issues

Reminders

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

Codecov Results 📊

282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 41.56s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 14775 uncovered lines.
✅ Project coverage is 33.63%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    33.63%    33.63%        —%
==========================================
  Files          190       190         —
  Lines        22260     22260         —
  Branches      7536      7536         —
==========================================
+ Hits          7485      7485         —
- Misses       14775     14775         —
- Partials       747       747         —

Generated by Codecov Action

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d91d454. Configure here.

Comment thread tests/integrations/starlette/test_starlette.py Outdated
Comment thread tests/integrations/starlette/test_starlette.py
@alexander-alderman-webb alexander-alderman-webb marked this pull request as draft May 18, 2026 08:02
@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review May 18, 2026 08:44
@alexander-alderman-webb alexander-alderman-webb marked this pull request as draft May 18, 2026 08:47
@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review May 18, 2026 09:08
Copy link
Copy Markdown
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! So much better than unit testing the internal request extractor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants