Skip to content

ref(wsgi): Remove unused segment name setting#6305

Merged
sentrivana merged 3 commits into
masterfrom
ivana/remove-post-segment-name-setting-in-wsgi
May 20, 2026
Merged

ref(wsgi): Remove unused segment name setting#6305
sentrivana merged 3 commits into
masterfrom
ivana/remove-post-segment-name-setting-in-wsgi

Conversation

@sentrivana
Copy link
Copy Markdown
Contributor

@sentrivana sentrivana commented May 20, 2026

Description

In span first, there is logic in the WSGI integration that sets the segment name and the source attribute to a generic default at the end of a segment span's lifecycle, unless the name/source have been set explicitly.

This logic is unnecessary. We create the segment with the default name and source, so there's no reason to rename again at the end. If the segment was renamed during its lifetime, that's the name we want to keep; the default is just a fallback.

Issues

Reminders

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Codecov Results 📊

282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 43.59s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 14885 uncovered lines.
✅ Project coverage is 33.43%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
wsgi.py 18.33% ⚠️ 147 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    33.42%    33.43%    +0.01%
==========================================
  Files          190       190         —
  Lines        22366     22360        -6
  Branches      7594      7588        -6
==========================================
+ Hits          7475      7475         —
- Misses       14891     14885        -6
- Partials       744       744         —

Generated by Codecov Action

@github-actions
Copy link
Copy Markdown
Contributor

Codecov Results 📊

5 passed | Total: 5 | Pass Rate: 100% | Execution Time: 810ms

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -2
Passed Tests 📉 -2
Failed Tests
Skipped Tests

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 17191 uncovered lines.
❌ Project coverage is 23.12%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
wsgi.py 18.33% ⚠️ 147 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    23.32%    23.12%     -0.2%
==========================================
  Files          190       190         —
  Lines        22366     22360        -6
  Branches      7594      7588        -6
==========================================
+ Hits          5216      5169       -47
- Misses       17150     17191       +41
- Partials       479       476        -3

Generated by Codecov Action

@sentrivana sentrivana marked this pull request as ready for review May 20, 2026 11:57
@sentrivana sentrivana requested a review from a team as a code owner May 20, 2026 11:57
@sentrivana sentrivana marked this pull request as draft May 20, 2026 11:58
@sentrivana sentrivana changed the title ref: Remove unused segment name setting ref(wsgi): Remove unused segment name setting May 20, 2026
@sentrivana sentrivana marked this pull request as ready for review May 20, 2026 11:59
Copy link
Copy Markdown
Contributor

@alexander-alderman-webb alexander-alderman-webb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect makes the Django migration simpler 🙏
I'll wait to merge mine after this is in

@sentrivana sentrivana enabled auto-merge (squash) May 20, 2026 12:04
@sentrivana sentrivana merged commit 882d364 into master May 20, 2026
156 checks passed
@sentrivana sentrivana deleted the ivana/remove-post-segment-name-setting-in-wsgi branch May 20, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants