ref(wsgi): Remove unused segment name setting#6305
Merged
sentrivana merged 3 commits intoMay 20, 2026
Conversation
Contributor
Codecov Results 📊✅ 282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 43.59s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 14885 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 33.42% 33.43% +0.01%
==========================================
Files 190 190 —
Lines 22366 22360 -6
Branches 7594 7588 -6
==========================================
+ Hits 7475 7475 —
- Misses 14891 14885 -6
- Partials 744 744 —Generated by Codecov Action |
Contributor
Codecov Results 📊✅ 5 passed | Total: 5 | Pass Rate: 100% | Execution Time: 810ms 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 17191 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 23.32% 23.12% -0.2%
==========================================
Files 190 190 —
Lines 22366 22360 -6
Branches 7594 7588 -6
==========================================
+ Hits 5216 5169 -47
- Misses 17150 17191 +41
- Partials 479 476 -3Generated by Codecov Action |
alexander-alderman-webb
approved these changes
May 20, 2026
Contributor
alexander-alderman-webb
left a comment
There was a problem hiding this comment.
Perfect makes the Django migration simpler 🙏
I'll wait to merge mine after this is in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In span first, there is logic in the WSGI integration that sets the segment name and the source attribute to a generic default at the end of a segment span's lifecycle, unless the name/source have been set explicitly.
This logic is unnecessary. We create the segment with the default name and source, so there's no reason to rename again at the end. If the segment was renamed during its lifetime, that's the name we want to keep; the default is just a fallback.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)