feat(pydantic-ai): Support span streaming#6389
Merged
Merged
Conversation
Contributor
Codecov Results 📊✅ 282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 43.34s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 14753 uncovered lines. Files with missing lines (6)
Generated by Codecov Action |
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
update_invoke_agent_span silently drops GEN_AI_RESPONSE_MODEL in span streaming mode
In sentry_sdk/integrations/pydantic_ai/spans/invoke_agent.py, update_invoke_agent_span calls span.set_data() unconditionally, but StreamedSpan only has set_attribute() — the resulting AttributeError is swallowed by the surrounding except Exception, so the response model name is silently never set when span streaming is enabled.
Evidence
StreamedSpan(defined insentry_sdk/traces.py:227) hasset_attribute/set_attributesbut noset_datamethod (confirmed via grep).update_invoke_agent_spancallsspan.set_data(SPANDATA.GEN_AI_RESPONSE_MODEL, response.model_name)atinvoke_agent.py:168without anisinstance(span, StreamedSpan)guard.- The call is wrapped in
try/except Exception, so theAttributeErroris silently eaten. ai_client_spanandexecute_tool_spanin the same PR both correctly useisinstance(span, StreamedSpan)checks (e.g.,execute_tool.py:update_execute_tool_span).- The new parametrized tests added in the hunk check
gen_ai.chatandgen_ai.execute_toolspans but not theinvoke_agentspan'sGEN_AI_RESPONSE_MODELattribute, so this regression goes undetected.
Identified by Warden code-review
sentrivana
approved these changes
May 22, 2026
Contributor
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
Looks good, small improvement suggestions in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
sentry_sdk.traces.start_spanand replaceSpan.set_data()withStreamedSpan.set_attribute()when in span streaming mode.Parametrize tests on the trace lifecycle option.
Issues
Closes #6046
Reminders
tox -e linters.feat:,fix:,ref:,meta:)