Skip to content

fix(ci): Bump Node to 22 in size-analysis and testflight workflows#5954

Merged
antonis merged 1 commit intomainfrom
fix/ci-node-22-sample-app-workflows
Apr 2, 2026
Merged

fix(ci): Bump Node to 22 in size-analysis and testflight workflows#5954
antonis merged 1 commit intomainfrom
fix/ci-node-22-sample-app-workflows

Conversation

@antonis
Copy link
Copy Markdown
Contributor

@antonis antonis commented Apr 2, 2026

📢 Type of change

  • Bugfix

📜 Description

Bump node-version from 18 to 22 in size-analysis.yml and testflight.yml workflows.

These two workflows build the RN sample app but were missed in the RN 0.84.1 bump PR (#5941), which only updated sample-application.yml and buildandtest.yml.

💡 Motivation and Context

RN 0.84.1 ships metro-config@0.82.2 which uses Array.prototype.toReversed() — a method not available in Node 18. This causes both workflows to fail with:

TypeError: configs.toReversed is not a function

Failing runs:

💚 How did you test it?

CI will validate — the failing workflows should pass with this change.

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

RN 0.84 ships metro-config 0.82.2 which uses Array.toReversed(),
requiring Node 20+. These two workflows build the sample app but
were missed in the RN 0.84.1 bump PR (#5941).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • fix(ci): Bump Node to 22 in size-analysis and testflight workflows by antonis in #5954
  • feat(playground): Open Sentry in desktop browser from Expo apps by antonis in #5947
  • chore(core): Bump sample app to React Native 0.84.1 by antonis in #5941
  • Size analysis for React Native SDK by alwx in #5949
  • chore(deps): bump lodash from 4.17.23 to 4.18.1 by dependabot in #5953
  • chore(deps): bump yauzl to ^3.2.1 by antonis in #5950
  • chore(deps): bump brace-expansion to ^2.0.3 by antonis in #5951
  • chore(deps): bump @xmldom/xmldom to fix XML injection by antonis in #5952

🤖 This preview updates automatically when you update the PR.

@antonis antonis added skip-changelog ready-to-merge Triggers the full CI test suite labels Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 493.25 ms 518.22 ms 24.97 ms
Size 43.75 MiB 48.08 MiB 4.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4953e94+dirty 442.02 ms 456.52 ms 14.50 ms
df5d108+dirty 527.06 ms 603.58 ms 76.52 ms
a50b33d+dirty 500.81 ms 532.11 ms 31.30 ms

App size

Revision Plain With Sentry Diff
4953e94+dirty 43.75 MiB 48.08 MiB 4.33 MiB
df5d108+dirty 43.75 MiB 48.08 MiB 4.33 MiB
a50b33d+dirty 43.75 MiB 48.08 MiB 4.33 MiB

@sentry
Copy link
Copy Markdown

sentry bot commented Apr 2, 2026

Sentry Build Distribution

App Name App ID Version Configuration Install Page
Sentry RN io.sentry.reactnative.sample 8.7.0 (82) Release Install Build

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1188.82 ms 1187.55 ms -1.27 ms
Size 3.38 MiB 4.73 MiB 1.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
df5d108+dirty 1225.90 ms 1220.14 ms -5.76 ms
4953e94+dirty 1212.06 ms 1214.83 ms 2.77 ms
a50b33d+dirty 1197.74 ms 1197.17 ms -0.57 ms

App size

Revision Plain With Sentry Diff
df5d108+dirty 3.38 MiB 4.73 MiB 1.35 MiB
4953e94+dirty 3.38 MiB 4.73 MiB 1.35 MiB
a50b33d+dirty 3.38 MiB 4.73 MiB 1.35 MiB

@antonis antonis merged commit ee2fefe into main Apr 2, 2026
112 of 138 checks passed
@antonis antonis deleted the fix/ci-node-22-sample-app-workflows branch April 2, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants