Closed
Conversation
Contributor
Author
|
It might be worthwhile adding a few more test cases. |
Member
andreynering
left a comment
andreynering
left a comment
There was a problem hiding this comment.
Hey @trulede,
The fixes in the PR are now already present in the codebase, so I'm closing this one.
If I'm missing anything, please let me know.
|
|
||
| func glob(dir string, g string) ([]string, error) { | ||
| g = filepathext.SmartJoin(dir, g) | ||
| g = strings.ReplaceAll(g, " ", `\ `) |
Member
There was a problem hiding this comment.
I think this is actually already being applied, but let me know if I'm missing anything.
ExpandFields called below already calls escape which converts " " into "\\ " as you're doing here.
| } | ||
| generates, err := Globs(t.Dir, t.Generates) | ||
| if err != nil { | ||
| generates := []string{} |
Member
There was a problem hiding this comment.
These changes were made on #2716, which also adds some good tests to this behavior. 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some problems with 'generates'.
1. Generates with timestamp method does not generate deleted files
Previously generated files, then deleted, are not regenerated when Task is subsequently run.
Solution is to adopt the glob mechanism from checksum. If a generate item is globbed and returns no files, or a NotExist error, then return indicating that the Task should run.
2. Generates (and sources) items with a space in filename will be expanded correctly.
Curiously, this problem is often masked by the first problem. In any case, it seems that a fix from long ago has been lost. The fix is introduced again, at a slightly different location (i.e. the glob() function).
Original fix here.
fixes #2314
fixes #1506
fixes #1230