Skip to content

fix: validate universe domain input to prevent SSRF credential leak #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adilburaksen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate universe domain input to prevent SSRF credential leak #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,16 @@ async function run() {
const region = presence(getInput('region')) || 'us-central1';
const universe = getInput('universe') || 'googleapis.com';

// Validate universe to prevent SSRF: an attacker-controlled value is
// interpolated into the Cloud Functions endpoint URL, routing credentials
// to an arbitrary host. Only googleapis.com and its subdomains are valid.
if (!/^([a-z0-9-]+\.)*googleapis\.com$/.test(universe)) {
throw new Error(
`Invalid universe domain "${universe}": must be "googleapis.com" or a valid ` +
`Trusted Partner Cloud subdomain (e.g. "us-central1.rep.googleapis.com").`,
);
}

// top-level inputs
const name = getInput('name', { required: true });
const description = presence(getInput('description'));
Expand Down