Skip to content

chore(firestore): skip pipeline verification tests outside enterprise db#16523

Merged
daniel-sanche merged 10 commits intomainfrom
fix_firestore_tests
Apr 7, 2026
Merged

chore(firestore): skip pipeline verification tests outside enterprise db#16523
daniel-sanche merged 10 commits intomainfrom
fix_firestore_tests

Conversation

@daniel-sanche
Copy link
Copy Markdown
Contributor

@daniel-sanche daniel-sanche commented Apr 1, 2026

Fixing problems with system tests (I'm not entirely sure why they started popping up now)

  • tests attempt to run pipeline verification tests on all test dbs. Pipelines mode is only supported on enterprise databases, so we should skip the test on unsupported environments
  • added unique ids to prevent parallel tests from interfering
  • [improvement] use pytest subtests to separate pipeline validation from rest of test

Diff is more complex than it should be, because adding subtests changed indentation

@daniel-sanche daniel-sanche requested review from a team as code owners April 1, 2026 22:04
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the verify_pipeline function in both synchronous and asynchronous system tests to include checks for the Firestore emulator and enterprise database requirements. The reviewer recommends using pytest.skip() instead of print() and return to ensure that tests are accurately reported as skipped in the test results, rather than appearing as passed when the conditions are not met.

Copy link
Copy Markdown
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Needs one minor fix to the documentation string for spelling/grammar.

NOTE: I don't think it is necessary for this PR, but it seems like it would be a useful future refactor to extract out the function(s) to a helper file in the repo rather than duplicating all that code. Especially since each function is so complicated with multiple levels of nesting, and so many conditionals.

That would probably be a good task for Gemini Code Assist and company.

Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
@daniel-sanche
Copy link
Copy Markdown
Contributor Author

Thanks for the review. Yeah, unfortunately there's a lot of mostly-duplicated code in this repo currently between the sync/async implementations. I'm hoping to clean it up using crosssync, once we move that outside the bigtable repo

@daniel-sanche daniel-sanche merged commit 3f07f69 into main Apr 7, 2026
31 checks passed
@daniel-sanche daniel-sanche deleted the fix_firestore_tests branch April 7, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants