chore(firestore): skip pipeline verification tests outside enterprise db#16523
chore(firestore): skip pipeline verification tests outside enterprise db#16523daniel-sanche merged 10 commits intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the verify_pipeline function in both synchronous and asynchronous system tests to include checks for the Firestore emulator and enterprise database requirements. The reviewer recommends using pytest.skip() instead of print() and return to ensure that tests are accurately reported as skipped in the test results, rather than appearing as passed when the conditions are not met.
packages/google-cloud-firestore/tests/system/test_system_async.py
Outdated
Show resolved
Hide resolved
chalmerlowe
left a comment
There was a problem hiding this comment.
LGTM. Needs one minor fix to the documentation string for spelling/grammar.
NOTE: I don't think it is necessary for this PR, but it seems like it would be a useful future refactor to extract out the function(s) to a helper file in the repo rather than duplicating all that code. Especially since each function is so complicated with multiple levels of nesting, and so many conditionals.
That would probably be a good task for Gemini Code Assist and company.
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
|
Thanks for the review. Yeah, unfortunately there's a lot of mostly-duplicated code in this repo currently between the sync/async implementations. I'm hoping to clean it up using crosssync, once we move that outside the bigtable repo |
Fixing problems with system tests (I'm not entirely sure why they started popping up now)
Diff is more complex than it should be, because adding subtests changed indentation